You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/09/22 11:55:04 UTC
[GitHub] storm pull request #1705: STORM-2117 Supervisor V2 with local mode extracts ...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1705
STORM-2117 Supervisor V2 with local mode extracts resources directory to the wrong directory
* it extracts the resources directory to topology root directory instead of temporary directory
* it should be extracted to temporary directory since we will move that directory to topology root directory
It didn't make unit tests failing, but I ran the tests from IntelliJ manually, IntelliJ adds some jars which contains resources directory, and this happens.
@revans2 Please take a look. Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2117
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1705.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1705
----
commit 26dc3a6ad333a79224eaac71d5876d0ea1db5853
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-09-22T11:46:11Z
STORM-2117 Supervisor V2 with local mode extracts resources directory to the wrong directory
* it extracts the resources directory to topology root directory instead of temporary directory
* it should be extracted to temporary directory since we will move that directory to topology root directory
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1705: STORM-2117 Supervisor V2 with local mode extracts resourc...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1705
+1
I'll pull this into #1697 too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1705: STORM-2117 Supervisor V2 with local mode extracts ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1705
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---