You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Dan Dumont (JIRA)" <ji...@apache.org> on 2012/08/29 21:12:07 UTC
[jira] [Created] (SHINDIG-1864) Refactor oauthpopup feature to use
rpc to the container
Dan Dumont created SHINDIG-1864:
-----------------------------------
Summary: Refactor oauthpopup feature to use rpc to the container
Key: SHINDIG-1864
URL: https://issues.apache.org/jira/browse/SHINDIG-1864
Project: Shindig
Issue Type: Improvement
Reporter: Dan Dumont
The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1864) Refactor oauthpopup feature to use
rpc to the container
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont resolved SHINDIG-1864.
---------------------------------
Resolution: Fixed
Committed r1383008
> Refactor oauthpopup feature to use rpc to the container
> -------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Fix For: 2.5.0-beta4
>
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1864) Change oauthpopup feature to do
window.open call from the container page
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1864:
--------------------------------
Component/s: Javascript
Java
> Change oauthpopup feature to do window.open call from the container page
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Dan Dumont
> Assignee: Dan Dumont
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
> This also paves the way for enhancements such as doing an oauth dance before a gadget even renders for pipelined data that is oauth protected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1864) Change oauthpopup feature to do
window.open call from the container page
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1864:
--------------------------------
Description:
The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
This also paves the way for enhancements such as doing an oauth dance before a gadget even renders for pipelined data that is oauth protected.
---------------------------
All oauthpopup changes made up until they were reverted are in the attached patch. There still exists a problem when this patch is applied where gadgets on a locked domain cannot complete the oauth dance.
This problem is discussed in this review: https://reviews.apache.org/r/7186/
was:
The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
This also paves the way for enhancements such as doing an oauth dance before a gadget even renders for pipelined data that is oauth protected.
> Change oauthpopup feature to do window.open call from the container page
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Attachments: shindig-project-upstream.patch
>
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
> This also paves the way for enhancements such as doing an oauth dance before a gadget even renders for pipelined data that is oauth protected.
> ---------------------------
> All oauthpopup changes made up until they were reverted are in the attached patch. There still exists a problem when this patch is applied where gadgets on a locked domain cannot complete the oauth dance.
> This problem is discussed in this review: https://reviews.apache.org/r/7186/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SHINDIG-1864) Refactor oauthpopup feature to use
rpc to the container
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont reassigned SHINDIG-1864:
-----------------------------------
Assignee: Dan Dumont
> Refactor oauthpopup feature to use rpc to the container
> -------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (SHINDIG-1864) Refactor oauthpopup feature to use
rpc to the container
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont reopened SHINDIG-1864:
---------------------------------
Reverted code as it was causing problems with OAuth 1.0a
Additional fixes are needed and under review, but a new beta needs to be pushed to fix the OAuth issue and patches need to be reviewed more comprehensively.
> Refactor oauthpopup feature to use rpc to the container
> -------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Fix For: 2.5.0-beta4
>
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1864) Refactor oauthpopup feature to
use rpc to the container
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459953#comment-13459953 ]
Dan Dumont commented on SHINDIG-1864:
-------------------------------------
Reverted all changes associated with this enhancement. Committed the revert in r1388199.
> Refactor oauthpopup feature to use rpc to the container
> -------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Fix For: 2.5.0-beta4
>
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1864) Refactor oauthpopup feature to
use rpc to the container
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459957#comment-13459957 ]
Dan Dumont commented on SHINDIG-1864:
-------------------------------------
Reverted all changes associated with this enhancement. Committed the revert in r1388199.
> Refactor oauthpopup feature to use rpc to the container
> -------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Fix For: 2.5.0-beta4
>
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1864) Change oauthpopup feature to do
window.open call from the container page
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1864:
--------------------------------
Fix Version/s: (was: 2.5.0-beta4)
> Change oauthpopup feature to do window.open call from the container page
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Dan Dumont
> Assignee: Dan Dumont
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
> This also paves the way for enhancements such as doing an oauth dance before a gadget even renders for pipelined data that is oauth protected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1864) Change oauthpopup feature to do
window.open call from the container page
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1864:
--------------------------------
Summary: Change oauthpopup feature to do window.open call from the container page (was: Refactor oauthpopup feature to use rpc to the container)
> Change oauthpopup feature to do window.open call from the container page
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Fix For: 2.5.0-beta4
>
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1864) Refactor oauthpopup feature to use
rpc to the container
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1864:
--------------------------------
Comment: was deleted
(was: Reverted all changes associated with this enhancement. Committed the revert in r1388199.
)
> Refactor oauthpopup feature to use rpc to the container
> -------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Fix For: 2.5.0-beta4
>
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1864) Refactor oauthpopup feature to use
rpc to the container
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont resolved SHINDIG-1864.
---------------------------------
Resolution: Fixed
Fix Version/s: 2.5.0-beta4
Committed r1380656
> Refactor oauthpopup feature to use rpc to the container
> -------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Fix For: 2.5.0-beta4
>
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1864) Change oauthpopup feature to do
window.open call from the container page
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1864:
--------------------------------
Description:
The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
This also paves the way for enhancements such as doing an oauth dance before a gadget even renders for pipelined data that is oauth protected.
was:The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
> Change oauthpopup feature to do window.open call from the container page
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Dan Dumont
> Assignee: Dan Dumont
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
> This also paves the way for enhancements such as doing an oauth dance before a gadget even renders for pipelined data that is oauth protected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1864) Change oauthpopup feature to do
window.open call from the container page
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1864:
--------------------------------
Attachment: shindig-project-upstream.patch
All oauthpopup changes made up until they were reverted. There still exists a problem when this patch is applied where gadgets on a locked domain cannot complete the oauth dance.
This problem is discussed in this review: https://reviews.apache.org/r/7186/
> Change oauthpopup feature to do window.open call from the container page
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Components: Java, Javascript
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Attachments: shindig-project-upstream.patch
>
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
> This also paves the way for enhancements such as doing an oauth dance before a gadget even renders for pipelined data that is oauth protected.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (SHINDIG-1864) Refactor oauthpopup feature to use
rpc to the container
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont reopened SHINDIG-1864:
---------------------------------
Still working out some issues with the mixin.
> Refactor oauthpopup feature to use rpc to the container
> -------------------------------------------------------
>
> Key: SHINDIG-1864
> URL: https://issues.apache.org/jira/browse/SHINDIG-1864
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Fix For: 2.5.0-beta4
>
>
> The container will now handle the launching of oauth requests and fire onopen and onclose events back into the requesting gadgets. This will allow container implementations to override the default behavior and possibly surface them in liteboxes rather than relying on window.open which is often prevented by popup blockers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira