You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Andrei Dulceanu (JIRA)" <ji...@apache.org> on 2017/02/09 16:41:41 UTC

[jira] [Updated] (OAK-5620) Simplify consistency check

     [ https://issues.apache.org/jira/browse/OAK-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Dulceanu updated OAK-5620:
---------------------------------
    Attachment: OAK-5620.patch

Locally, tests on valid repositories (including those in OAK-5600) look good.
[~mduerig], could you take a look at the patch attached?

/cc [~frm]

> Simplify consistency check
> --------------------------
>
>                 Key: OAK-5620
>                 URL: https://issues.apache.org/jira/browse/OAK-5620
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: run, segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>              Labels: tooling
>             Fix For: 1.7.0, 1.8
>
>         Attachments: OAK-5620.patch
>
>
> The current implementation of the consistency check ({{ConsistencyChecker}},{{CheckCommand}})
> is cluttered with unnecessary checks regarding deprecated arguments of the {{check}} command. 
> With OAK-5595, deep traversals are enabled by default, therefore the code needs to be revised to take this into account. The same applies to the argument taken by {{--bin}} option, which was removed in OAK-5604.
> Moreover, {{ConsistencyChecker}} could be refactored in order to better distinguish when:
> * a full path at the given revision is checked
> * a node and its properties are checked
> * a node and its descendants are checked



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)