You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/22 08:07:49 UTC
[GitHub] [shardingsphere] FlyingZC opened a new pull request, #19468: Support transaction integration tests to run in the JDBC container
FlyingZC opened a new pull request, #19468:
URL: https://github.com/apache/shardingsphere/pull/19468
Changes proposed in this pull request:
- Support transaction integration tests to run in the JDBC container;
- Add PostgreSQL set read only transaction integration test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on a diff in pull request #19468: Support transaction integration tests to run in the JDBC container
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on code in PR #19468:
URL: https://github.com/apache/shardingsphere/pull/19468#discussion_r928379203
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/cases/savepoint/PostgreSQLSavePointTestCase.java:
##########
@@ -54,19 +53,7 @@ private void assertErrors() {
conn.setSavepoint("point");
Assert.fail("Expect exception, but no exception report.");
} catch (SQLException ex) {
- Assert.assertEquals("25P01", ex.getSQLState());
- }
- try {
- conn.rollback(new PSQLSavepoint("point1"));
- Assert.fail("Expect exception, but no exception report.");
- } catch (SQLException ex) {
- Assert.assertTrue(ex.getMessage().endsWith("ERROR: ROLLBACK TO SAVEPOINT can only be used in transaction blocks"));
- }
- try {
- conn.releaseSavepoint(new PSQLSavepoint("point1"));
- Assert.fail("Expect exception, but no exception report.");
- } catch (SQLException ex) {
- Assert.assertTrue(ex.getMessage().endsWith("ERROR: RELEASE SAVEPOINT can only be used in transaction blocks"));
Review Comment:
Why delete this one? If deleted, some scenes cannot be covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu merged pull request #19468: Support transaction integration tests to run in the JDBC container
Posted by GitBox <gi...@apache.org>.
jingshanglu merged PR #19468:
URL: https://github.com/apache/shardingsphere/pull/19468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] FlyingZC commented on a diff in pull request #19468: Support transaction integration tests to run in the JDBC container
Posted by GitBox <gi...@apache.org>.
FlyingZC commented on code in PR #19468:
URL: https://github.com/apache/shardingsphere/pull/19468#discussion_r928465312
##########
shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-transaction/src/test/java/org/apache/shardingsphere/integration/transaction/cases/savepoint/PostgreSQLSavePointTestCase.java:
##########
@@ -54,19 +53,7 @@ private void assertErrors() {
conn.setSavepoint("point");
Assert.fail("Expect exception, but no exception report.");
} catch (SQLException ex) {
- Assert.assertEquals("25P01", ex.getSQLState());
- }
- try {
- conn.rollback(new PSQLSavepoint("point1"));
- Assert.fail("Expect exception, but no exception report.");
- } catch (SQLException ex) {
- Assert.assertTrue(ex.getMessage().endsWith("ERROR: ROLLBACK TO SAVEPOINT can only be used in transaction blocks"));
- }
- try {
- conn.releaseSavepoint(new PSQLSavepoint("point1"));
- Assert.fail("Expect exception, but no exception report.");
- } catch (SQLException ex) {
- Assert.assertTrue(ex.getMessage().endsWith("ERROR: RELEASE SAVEPOINT can only be used in transaction blocks"));
Review Comment:
These two cases can't run successful in jdbc mode.I will restore the code and not run the cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org