You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/29 07:20:59 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request, #21840: Revise pr 21789

strongduanmu opened a new pull request, #21840:
URL: https://github.com/apache/shardingsphere/pull/21840

   Ref #21789.
   
   Changes proposed in this pull request:
     - Revise pr 21789
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #21840: Revise pr 21789

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21840:
URL: https://github.com/apache/shardingsphere/pull/21840#issuecomment-1295763879

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21840?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#21840](https://codecov.io/gh/apache/shardingsphere/pull/21840?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (557ca57) into [master](https://codecov.io/gh/apache/shardingsphere/commit/05a88dc658d47f9f89cd2a948ffb9ccfeefef40d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05a88dc) will **not change** coverage.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #21840   +/-   ##
   =========================================
     Coverage     60.85%   60.85%           
     Complexity     2446     2446           
   =========================================
     Files          4107     4107           
     Lines         57339    57339           
     Branches       9684     9684           
   =========================================
     Hits          34894    34894           
     Misses        19541    19541           
     Partials       2904     2904           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21840?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/spring/boot/ShardingSphereAutoConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/21840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amRiYy9zcHJpbmcvY29yZS9zcHJpbmctYm9vdC1zdGFydGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvYm9vdC9TaGFyZGluZ1NwaGVyZUF1dG9Db25maWd1cmF0aW9uLmphdmE=) | `66.66% <ø> (ø)` | |
   | [...t/condition/ShardingSphereSpringBootCondition.java](https://codecov.io/gh/apache/shardingsphere/pull/21840/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amRiYy9zcHJpbmcvY29yZS9zcHJpbmctYm9vdC1zdGFydGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvYm9vdC9jb25kaXRpb24vU2hhcmRpbmdTcGhlcmVTcHJpbmdCb290Q29uZGl0aW9uLmphdmE=) | `50.00% <0.00%> (ø)` | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tristaZero merged pull request #21840: Revise pr 21789

Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #21840:
URL: https://github.com/apache/shardingsphere/pull/21840


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org