You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/19 20:07:44 UTC

[GitHub] [spark] MaxGekk opened a new pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 commands

MaxGekk opened a new pull request #31596:
URL: https://github.com/apache/spark/pull/31596


   ### What changes were proposed in this pull request?
   In the PR, I propose to rename logical nodes of v2 commands in the form: `<verb> + <object>` like:
   - AlterTableAddPartition -> AddPartition
   - AlterTableSetLocation -> SetTableLocation
   
   ### Why are the changes needed?
   1. For simplicity and readability of logical plans
   2. For consistency with other logical nodes. For example, the logical node `RenameTable` for `ALTER TABLE .. RENAME TO` was added before `AlterTableRenamePartition`.
   
   ### Does this PR introduce _any_ user-facing change?
   Should not since this is non-public APIs.
   
   ### How was this patch tested?
   1. Check scala style: `./dev/scalastyle`
   2. Affected test suites:
   ```
   $ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *AlterTableRenamePartitionSuite"
   ```
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31596:
URL: https://github.com/apache/spark/pull/31596#discussion_r579974151



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -712,7 +712,7 @@ case class AlterTableDropPartition(
 /**
  * The logical plan of the ALTER TABLE ... RENAME TO PARTITION command.
  */
-case class AlterTableRenamePartition(
+case class RenamePartition(

Review comment:
       yea, to be consistent with ADD and DROP




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31596:
URL: https://github.com/apache/spark/pull/31596


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31596:
URL: https://github.com/apache/spark/pull/31596#discussion_r579488025



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -876,7 +876,7 @@ case class UncacheTable(
 /**
  * The logical plan of the ALTER TABLE ... SET LOCATION command.
  */
-case class AlterTableSetLocation(
+case class SetTableLocation(

Review comment:
       The command incapsulates 2 commands actually: set table location and set partition location. Should we split it to `SetTableLocation` and `SetPartitionLocation` (separately in another PR).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783213224


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39919/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31596:
URL: https://github.com/apache/spark/pull/31596#discussion_r579484987



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -808,11 +808,11 @@ class PlanResolutionSuite extends AnalysisTest {
 
     // For non-existing tables, we convert it to v2 command with `UnresolvedV2Table`
     parsed4 match {
-      case AlterTableSetProperties(_: UnresolvedTable, _) => // OK
+      case SetTableProperties(_: UnresolvedTable, _) => // OK
       case _ => fail("Expect AlterTableSetProperties, but got:\n" + parsed4.treeString)

Review comment:
       @imback82 Thank you. Maybe, we should replace it by `${SetTableProperties.getClass.getName}` to easily find it in IDE.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782324615


   **[Test build #135277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135277/testReport)** for PR 31596 at commit [`5109748`](https://github.com/apache/spark/commit/5109748ac30ebab8695c1d6c91b40774d2a3553a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783195866


   **[Test build #135339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135339/testReport)** for PR 31596 at commit [`f6ab9ab`](https://github.com/apache/spark/commit/f6ab9ab4c127723a24066c559e0389b0a48bf1f2).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783299885


   **[Test build #135334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135334/testReport)** for PR 31596 at commit [`09e7268`](https://github.com/apache/spark/commit/09e7268b9bac02a988c1cf5548b33bb41351182b).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `case class RenamePartitions(`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783345450


   **[Test build #135339 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135339/testReport)** for PR 31596 at commit [`f6ab9ab`](https://github.com/apache/spark/commit/f6ab9ab4c127723a24066c559e0389b0a48bf1f2).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782892446


   cc @cloud-fan 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] imback82 commented on a change in pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #31596:
URL: https://github.com/apache/spark/pull/31596#discussion_r579464269



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -808,11 +808,11 @@ class PlanResolutionSuite extends AnalysisTest {
 
     // For non-existing tables, we convert it to v2 command with `UnresolvedV2Table`
     parsed4 match {
-      case AlterTableSetProperties(_: UnresolvedTable, _) => // OK
+      case SetTableProperties(_: UnresolvedTable, _) => // OK
       case _ => fail("Expect AlterTableSetProperties, but got:\n" + parsed4.treeString)

Review comment:
       Same for other places.

##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala
##########
@@ -808,11 +808,11 @@ class PlanResolutionSuite extends AnalysisTest {
 
     // For non-existing tables, we convert it to v2 command with `UnresolvedV2Table`
     parsed4 match {
-      case AlterTableSetProperties(_: UnresolvedTable, _) => // OK
+      case SetTableProperties(_: UnresolvedTable, _) => // OK
       case _ => fail("Expect AlterTableSetProperties, but got:\n" + parsed4.treeString)

Review comment:
       Update this message?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31596:
URL: https://github.com/apache/spark/pull/31596#discussion_r579974268



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -876,7 +876,7 @@ case class UncacheTable(
 /**
  * The logical plan of the ALTER TABLE ... SET LOCATION command.
  */
-case class AlterTableSetLocation(
+case class SetTableLocation(

Review comment:
       SGTM




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782487927


   **[Test build #135277 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135277/testReport)** for PR 31596 at commit [`5109748`](https://github.com/apache/spark/commit/5109748ac30ebab8695c1d6c91b40774d2a3553a).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-784153140


   thanks, merging to master!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783128287


   **[Test build #135334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135334/testReport)** for PR 31596 at commit [`09e7268`](https://github.com/apache/spark/commit/09e7268b9bac02a988c1cf5548b33bb41351182b).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782646665


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39892/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783182555


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39914/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783369940


   no, logical plan is not a public API.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782376377


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39858/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782324615


   **[Test build #135277 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135277/testReport)** for PR 31596 at commit [`5109748`](https://github.com/apache/spark/commit/5109748ac30ebab8695c1d6c91b40774d2a3553a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782490451


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135277/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783162075


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39914/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782610088


   **[Test build #135312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135312/testReport)** for PR 31596 at commit [`6da1d08`](https://github.com/apache/spark/commit/6da1d085a8a078d89d27766ffa0e6947b561f140).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782696395


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135312/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782696395


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135312/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783301020


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135334/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782610088


   **[Test build #135312 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135312/testReport)** for PR 31596 at commit [`6da1d08`](https://github.com/apache/spark/commit/6da1d085a8a078d89d27766ffa0e6947b561f140).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783146768


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39914/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783301020


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135334/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783094003


   @HyukjinKwon @cloud-fan @dongjoon-hyun Can this be merged to `branch-3.1`? Most (or all) of the nodes were added after 3.0, and they haven't released yet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 commands

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31596:
URL: https://github.com/apache/spark/pull/31596#discussion_r579448216



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -676,7 +676,7 @@ case class AnalyzeColumn(
  *                 PARTITION spec1 [LOCATION 'loc1'][, PARTITION spec2 [LOCATION 'loc2'], ...];
  * }}}
  */
-case class AlterTableAddPartition(
+case class AddPartition(

Review comment:
       Maybe `AddPartitions` because the command can add multiple partitions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783261785


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39919/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782490451


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135277/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782352601


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39858/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783365794


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135339/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783182555


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39914/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782394682


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39858/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783197241


   RC3 is cut and I don't think we should do this refactor in 3.1.2 (assuming RC3 passes).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31596:
URL: https://github.com/apache/spark/pull/31596#discussion_r579486443



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -712,7 +712,7 @@ case class AlterTableDropPartition(
 /**
  * The logical plan of the ALTER TABLE ... RENAME TO PARTITION command.
  */
-case class AlterTableRenamePartition(
+case class RenamePartition(

Review comment:
       Even now, we allow to rename only one partition but Hive supports renaming of multiple partitions in one command. Maybe Spark will support this too in the future. Should we name it as `RenamePartitions`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782646665


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39892/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782696121


   **[Test build #135312 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135312/testReport)** for PR 31596 at commit [`6da1d08`](https://github.com/apache/spark/commit/6da1d085a8a078d89d27766ffa0e6947b561f140).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `case class DropPartitions(`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783128287


   **[Test build #135334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135334/testReport)** for PR 31596 at commit [`09e7268`](https://github.com/apache/spark/commit/09e7268b9bac02a988c1cf5548b33bb41351182b).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #31596:
URL: https://github.com/apache/spark/pull/31596#discussion_r579485627



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -698,7 +698,7 @@ case class AlterTableAddPartition(
  *     ALTER TABLE table DROP [IF EXISTS] PARTITION spec1[, PARTITION spec2, ...] [PURGE];
  * }}}
  */
-case class AlterTableDropPartition(
+case class DropPartition(

Review comment:
       `DropPartition` -> `DropPartitions`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-782394682


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39858/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783261785


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39919/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783195866


   **[Test build #135339 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135339/testReport)** for PR 31596 at commit [`f6ab9ab`](https://github.com/apache/spark/commit/f6ab9ab4c127723a24066c559e0389b0a48bf1f2).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783358325


   > RC3 is cut and I don't think we should do this refactor in 3.1.2 (assuming RC3 passes).
   
   @cloud-fan, hm are there any API change here?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783233410


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39919/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #31596: [SPARK-34475][SQL] Rename logical nodes of v2 `ALTER` commands

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31596:
URL: https://github.com/apache/spark/pull/31596#issuecomment-783365794


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135339/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org