[GitHub] [incubator-pinot] fx19880617 edited a comment on pull request #6359: 6355 don't lose authority portion of inputDirURI

[GitBox <gi...@apache.org>]

fx19880617 edited a comment on pull request #6359:
URL: https://github.com/apache/incubator-pinot/pull/6359#issuecomment-745750374


   Thanks! 
   Can you also add a test for `SegmentGenerationUtils.getRelativeOutputPath(...)` with the example you have. So we can ensure this works for your use case. 
   
   Basically this logic: 
   ```
   URI outputSegmentTarURI = SegmentGenerationUtils.getRelativeOutputPath(inputDirURI, inputFileURI, outputDirURI).resolve(segmentTarFileName);
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org