You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by co...@apache.org on 2017/02/07 12:58:57 UTC

ranger git commit: Minor cleanup

Repository: ranger
Updated Branches:
  refs/heads/master 653d86c48 -> d6d5c2c31


Minor cleanup


Project: http://git-wip-us.apache.org/repos/asf/ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/d6d5c2c3
Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/d6d5c2c3
Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/d6d5c2c3

Branch: refs/heads/master
Commit: d6d5c2c3127f1d47a99637a95d34edb7559ee160
Parents: 653d86c
Author: Colm O hEigeartaigh <co...@apache.org>
Authored: Tue Feb 7 12:58:47 2017 +0000
Committer: Colm O hEigeartaigh <co...@apache.org>
Committed: Tue Feb 7 12:58:47 2017 +0000

----------------------------------------------------------------------
 .../org/apache/ranger/tagsync/process/TagSynchronizer.java     | 2 +-
 .../ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java  | 4 +---
 .../ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java   | 6 +++---
 .../apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java  | 4 ++--
 4 files changed, 7 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ranger/blob/d6d5c2c3/tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java
----------------------------------------------------------------------
diff --git a/tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java b/tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java
index a9098be..d36ecae 100644
--- a/tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java
+++ b/tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java
@@ -271,7 +271,7 @@ public class TagSynchronizer {
 		}
 
 		if (LOG.isDebugEnabled()) {
-			LOG.debug("<== TagSynchronizer.initializeTagSources(initilaizedTagSources=" + initializedTagSourceNameList
+			LOG.debug("<== TagSynchronizer.initializeTagSources(initializedTagSources=" + initializedTagSourceNameList
 					+ ", failedTagSources=" + failedTagSources + ")");
 		}
 	}

http://git-wip-us.apache.org/repos/asf/ranger/blob/d6d5c2c3/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java
----------------------------------------------------------------------
diff --git a/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java b/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java
index 272328e..9f1fc2d 100644
--- a/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java
+++ b/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java
@@ -70,8 +70,6 @@ public class AtlasKafkaResourceMapper extends AtlasResourceMapper {
 		String  entityGuid  = entity.getId() != null ? entity.getId()._getId() : null;
 		String  serviceName = getRangerServiceName(clusterName);
 
-		RangerServiceResource ret = new RangerServiceResource(entityGuid, serviceName, elements);
-
-		return ret;
+		return new RangerServiceResource(entityGuid, serviceName, elements);
 	}
 }

http://git-wip-us.apache.org/repos/asf/ranger/blob/d6d5c2c3/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java
----------------------------------------------------------------------
diff --git a/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java b/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java
index b8f5c46..f9f0eaf 100644
--- a/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java
+++ b/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java
@@ -75,7 +75,7 @@ public class AtlasResourceMapperUtil {
 	}
 
 	static public boolean initializeAtlasResourceMappers(Properties properties) {
-		final String MAPPER_NAME_DELIMIER = ",";
+		final String MAPPER_NAME_DELIMITER = ",";
 
 		String customMapperNames = TagSyncConfig.getCustomAtlasResourceMappers(properties);
 
@@ -91,14 +91,14 @@ public class AtlasResourceMapperUtil {
 		mapperNames.add("org.apache.ranger.tagsync.source.atlas.AtlasKafkaResourceMapper");
 
 		if (StringUtils.isNotBlank(customMapperNames)) {
-			for(String customMapperName : customMapperNames.split(MAPPER_NAME_DELIMIER)) {
+			for (String customMapperName : customMapperNames.split(MAPPER_NAME_DELIMITER)) {
 				mapperNames.add(customMapperName.trim());
 			}
 		}
 
 		for (String mapperName : mapperNames) {
 			try {
-				Class clazz = Class.forName(mapperName);
+				Class<?> clazz = Class.forName(mapperName);
 				AtlasResourceMapper resourceMapper = (AtlasResourceMapper) clazz.newInstance();
 
 				resourceMapper.initialize(properties);

http://git-wip-us.apache.org/repos/asf/ranger/blob/d6d5c2c3/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java
----------------------------------------------------------------------
diff --git a/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java b/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java
index cca7caf..bf09cfd 100644
--- a/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java
+++ b/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java
@@ -105,7 +105,7 @@ public class AtlasRESTUtil {
 
 				if (!AtlasResourceMapperUtil.isEntityTypeHandled(type)) {
 					if (LOG.isDebugEnabled()) {
-						LOG.debug("Not fetching Atlas entities of type:" + type);
+						LOG.debug("Not fetching Atlas entities of type: " + type);
 					}
 					continue;
 				}
@@ -116,7 +116,7 @@ public class AtlasRESTUtil {
 
 				if (CollectionUtils.isEmpty(guids)) {
 					if (LOG.isDebugEnabled()) {
-						LOG.debug("No Atlas entities for type:" + type);
+						LOG.debug("No Atlas entities for type: " + type);
 					}
 					continue;
 				}