You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/16 09:08:40 UTC
[GitHub] [incubator-kyuubi] yulongz opened a new issue #1917: [Improvement] Rename some package named with ‘logs’
yulongz opened a new issue #1917:
URL: https://github.com/apache/incubator-kyuubi/issues/1917
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
Usually ，the directory name ‘logs’ is included in the file ‘.gitignore’ . Kyuubi contians some package names with logs , for example , ’org.apache.kyuubi.jdbc.hive.logs‘ and ‘org.apache.hive.beeline.logs’ . Some git operations will lose processing of files in this package.
### How should we improve?
Rename package name wich 'logs' will avoid some misoperations and offer some convenience. For example , maybe we can rename 'logs' to 'logutils'.
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas edited a comment on issue #1917: [Improvement] Rename some package named with ‘logs’
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on issue #1917:
URL: https://github.com/apache/incubator-kyuubi/issues/1917#issuecomment-1044115677
@yulongz, IMO, you could update the `.gitignore` for above, not rename the package. cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on issue #1917: [Improvement] Rename some package named with ‘logs’
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #1917:
URL: https://github.com/apache/incubator-kyuubi/issues/1917#issuecomment-1044115677
@yulongz, IMO, you could update the `.gitnore` for above, not rename the package. cc @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed issue #1917: [Improvement] Rename some package named with ‘logs’
Posted by GitBox <gi...@apache.org>.
yaooqinn closed issue #1917:
URL: https://github.com/apache/incubator-kyuubi/issues/1917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on issue #1917: [Improvement] Rename some package named with ‘logs’
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #1917:
URL: https://github.com/apache/incubator-kyuubi/issues/1917#issuecomment-1044237380
@yulongz, you could add the path to the `.gitignore`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas edited a comment on issue #1917: [Improvement] Rename some package named with ‘logs’
Posted by GitBox <gi...@apache.org>.
SteNicholas edited a comment on issue #1917:
URL: https://github.com/apache/incubator-kyuubi/issues/1917#issuecomment-1044237380
@yulongz, you could add the path mentioned above to the `.gitignore`. Would you like to contribute a pull request for above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] SteNicholas commented on issue #1917: [Improvement] Rename some package named with ‘logs’
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on issue #1917:
URL: https://github.com/apache/incubator-kyuubi/issues/1917#issuecomment-1055391471
@yaooqinn, this issue has no response. IMO. this could be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #1917: [Improvement] Rename some package named with ‘logs’
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #1917:
URL: https://github.com/apache/incubator-kyuubi/issues/1917#issuecomment-1055417847
+1 to close this，free free to open it if youthink this is still an issue that needs to be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yulongz commented on issue #1917: [Improvement] Rename some package named with ‘logs’
Posted by GitBox <gi...@apache.org>.
yulongz commented on issue #1917:
URL: https://github.com/apache/incubator-kyuubi/issues/1917#issuecomment-1044217150
@SteNicholas Whether the file ‘https://github.com/apache/incubator-kyuubi/blob/master/.gitignore’ should contain the line 'logs/'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] github-actions[bot] commented on issue #1917: [Improvement] Rename some package named with ‘logs’
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #1917:
URL: https://github.com/apache/incubator-kyuubi/issues/1917#issuecomment-1041269034
Hello @yulongz,
Thanks for finding the time to report the issue!
We really appreciate the community's efforts to improve Apache Kyuubi (Incubating).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org