[GitHub] janpio commented on a change in pull request #319: Windows Platform Release Preparation (Cordova 9)

[GitBox <gi...@apache.org>]

janpio commented on a change in pull request #319: Windows Platform Release Preparation (Cordova 9)
URL: https://github.com/apache/cordova-windows/pull/319#discussion_r246376386
 
 

 ##########
 File path: template/cordova/prebuild.js
 ##########
 @@ -50,7 +50,9 @@ module.exports = function patch (platform) {
     // 1. Find start page path in appxmanifest
     var AppxManifest = require('./lib/AppxManifest');
     var appxmanifest = AppxManifest.get(path.join(__dirname, '..', appxmanifestMap[platform]));
-    var startPage = url.parse(appxmanifest.getApplication().getStartPage());
+
+    // @todo Use 'url.URL' constructor instead
 
 Review comment:
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org