You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/04/25 01:44:29 UTC
[GitHub] [pinot] diogobaeder opened a new issue, #8586: Documentation issues for JSON columns
diogobaeder opened a new issue, #8586:
URL: https://github.com/apache/pinot/issues/8586
Hi folks,
There's a few issues in the documentation for handling JSON columns.
In the documentation for handling JSON columns with JSON indexing, the configuration there is missing a top-level `ingestionConfig` configuration on the table config, and only inside `ingestionConfig` is where we should put `transformConfigs`. Also, that configuration part in the docs could be better formatted to have more consistent indentation.
And I also think the documentation should be using the `JSON` column type, not `STRING`; Even though both might work, using `JSON` is more consistent and is actually the type being used in the file that contains the "full spec": https://github.com/apache/pinot/blob/master/pinot-tools/src/main/resources/examples/stream/meetupRsvp/json_meetupRsvp_schema.json
One more thing that would be worth mentioning in the documentation is that the column name in the source data that is used for ingestion has to be different from the destination column name; For example, if I want column `foo` in Pinot as JSON, then in my source I should use something different like `foo_source`. Ideally though, it would be awesome if Pinot could just take care of such fields without us having to have different names and having to define a transformation function - Pinot could use `jsonFormat` by default on the fields that use `JSON` type, just to reduce configuration boilerplate.
Thanks!
Diogo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #8586: Documentation issues for JSON columns
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #8586:
URL: https://github.com/apache/pinot/issues/8586#issuecomment-1110209864
@diogobaeder Thanks for pointing out the issues. Would you like to help us improve the documentation for JSON? You may find the source code under this repo: https://github.com/pinot-contrib/pinot-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] mneedham commented on issue #8586: Documentation issues for JSON columns
Posted by GitBox <gi...@apache.org>.
mneedham commented on issue #8586:
URL: https://github.com/apache/pinot/issues/8586#issuecomment-1112154379
@diogobaeder have applied your feedback to the docs - https://docs.pinot.apache.org/basics/data-import/complex-type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] diogobaeder closed issue #8586: Documentation issues for JSON columns
Posted by GitBox <gi...@apache.org>.
diogobaeder closed issue #8586: Documentation issues for JSON columns
URL: https://github.com/apache/pinot/issues/8586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] diogobaeder commented on issue #8586: Documentation issues for JSON columns
Posted by GitBox <gi...@apache.org>.
diogobaeder commented on issue #8586:
URL: https://github.com/apache/pinot/issues/8586#issuecomment-1110213753
@Jackie-Jiang sure! I'll fork it and send a PR, thanks :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] diogobaeder commented on issue #8586: Documentation issues for JSON columns
Posted by GitBox <gi...@apache.org>.
diogobaeder commented on issue #8586:
URL: https://github.com/apache/pinot/issues/8586#issuecomment-1112184281
Awesome, thanks @mneedham ! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org