[GitHub] [incubator-doris] morningman commented on a change in pull request #1800: Fix bug that dead lock may happen when drop table during alter table process

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #1800: Fix bug that dead lock may happen when drop table during alter table process
URL: https://github.com/apache/incubator-doris/pull/1800#discussion_r323824297
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java
 ##########
 @@ -165,8 +173,7 @@ protected void runPendingJob() {
         try {
             OlapTable tbl = (OlapTable) db.getTable(tableId);
             if (tbl == null) {
-                cancelImpl("Table " + tableId + " does not exist");
-                return;
+                return new Status(TStatusCode.CANCELLED, "Table " + tableId + " does not exist");
 
 Review comment:
   That I have to define a new kind of exception for this, which is...eh...complicated..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org