You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "yxinot (via GitHub)" <gi...@apache.org> on 2026/10/03 07:52:11 UTC

[PR] [ZEPPELIN-5658] Fix infinite recursion in AzureNotebookRepo.list() [zeppelin]

yxinot opened a new pull request, #5522:
URL: https://github.com/apache/zeppelin/pull/5522

   ### What is this PR for?
     Fix infinite recursion (`StackOverflowError`) in `AzureNotebookRepo.list()` when notebooks are stored in subdirectories. The private `list(CloudFileDirectory folder)` method was iterating over `rootDir` instead of the `folder` parameter, causing the recursive call to never descend and loop infinitely.                                  
      
     ### What type of PR is it?                                                                                                                                               
     Bug Fix                                                   
                                                                                                                                                                              
     ### Todos                                                 
     * [x] - Fix `rootDir` → `folder` in `AzureNotebookRepo.list()`                                                                                                           
                                                                                                                                                                              
     ### What is the Jira issue?                                                                                                                                              
     * https://issues.apache.org/jira/browse/ZEPPELIN-5658                                                                                                                    
                                                                                                                                                                              
     ### How should this be tested?                                                                                                                                           
     * No existing unit tests (Azure infrastructure dependency)                                                                                                               
     * The fix is a single-variable change correcting a clear copy-paste error where the method parameter was completely ignored                                              
     * Manual test: deploy Zeppelin with Azure Storage backend, create notebooks in subdirectories, and verify they persist across restarts without `StackOverflowError`      
                                                                                                                                                                              
     ### Screenshots (if appropriate)                                                                                                                                         
     N/A                                                                                                                                                                      
                                                                                                                                                                              
     ### Questions:                                            
     * Does the license files need to update? No                                                                                                                              
     * Is there breaking changes for older versions? No                                                                                                                       
     * Does this needs documentation? No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-5658] Fix infinite recursion in AzureNotebookRepo.list() [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5522:
URL: https://github.com/apache/zeppelin/pull/5522


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-5658] Fix infinite recursion in AzureNotebookRepo.list() [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5522:
URL: https://github.com/apache/zeppelin/pull/5522#issuecomment-5970558757

   Merged into master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org