You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/12 03:37:15 UTC
[GitHub] [dubbo-samples] shengchaojie opened a new pull request #251: fix dubbo-samples-generic it
shengchaojie opened a new pull request #251:
URL: https://github.com/apache/dubbo-samples/pull/251
fix dubbo-samples-generic it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #251: fix dubbo-samples-generic it
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #251:
URL: https://github.com/apache/dubbo-samples/pull/251#discussion_r555535271
##########
File path: dubbo-samples-generic/dubbo-samples-generic-impl/case-configuration.yml
##########
@@ -18,6 +18,7 @@ from: app-builtin-zookeeper.yml
props:
project_name: dubbo-samples-generic-impl-provider
Review comment:
project_name 建议改成目录名吧
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] shengchaojie commented on a change in pull request #251: fix dubbo-samples-generic it
Posted by GitBox <gi...@apache.org>.
shengchaojie commented on a change in pull request #251:
URL: https://github.com/apache/dubbo-samples/pull/251#discussion_r556220838
##########
File path: dubbo-samples-generic/dubbo-samples-generic-impl/case-configuration.yml
##########
@@ -18,6 +18,7 @@ from: app-builtin-zookeeper.yml
props:
project_name: dubbo-samples-generic-impl-provider
Review comment:
好滴，马上提
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] shengchaojie commented on a change in pull request #251: fix dubbo-samples-generic it
Posted by GitBox <gi...@apache.org>.
shengchaojie commented on a change in pull request #251:
URL: https://github.com/apache/dubbo-samples/pull/251#discussion_r555543345
##########
File path: dubbo-samples-generic/dubbo-samples-generic-impl/case-configuration.yml
##########
@@ -18,6 +18,7 @@ from: app-builtin-zookeeper.yml
props:
project_name: dubbo-samples-generic-impl-provider
Review comment:
👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj merged pull request #251: fix dubbo-samples-generic it
Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #251:
URL: https://github.com/apache/dubbo-samples/pull/251
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #251: fix dubbo-samples-generic it
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #251:
URL: https://github.com/apache/dubbo-samples/pull/251#discussion_r555847249
##########
File path: dubbo-samples-generic/dubbo-samples-generic-impl/case-configuration.yml
##########
@@ -18,6 +18,7 @@ from: app-builtin-zookeeper.yml
props:
project_name: dubbo-samples-generic-impl-provider
Review comment:
请将project_name 改为dubbo-samples-generic-impl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org