[GitHub] liubao68 commented on a change in pull request #767: [SCB-662]Using cse/servicecomb duplicate key will get list of values

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #767: [SCB-662]Using cse/servicecomb duplicate key will get list of values
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/767#discussion_r194969232
 
 

 ##########
 File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java
 ##########
 @@ -171,7 +171,14 @@ private static void duplicateServiceCombConfigToCse(AbstractConfiguration source
       }
 
       String cseKey = CONFIG_CSE_PREFIX + key.substring(key.indexOf(".") + 1);
-      source.addProperty(cseKey, source.getProperty(key));
+      if (!source.containsKey(cseKey)) {
+        source.addProperty(cseKey, source.getProperty(key));
+      } else {
+        LOGGER
+            .warn(
 
 Review comment:
   As shown in test case, this can work. Just when merge, it will not take the cse-config-order(which is implemented by config-cc). We can not cover all orders for ConfigurationsImpl, so give a warning  message. 
   If we cover this, we need to change any implementations. This is not a good idea. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services