You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by cxfeng1 <gi...@git.apache.org> on 2017/07/26 02:59:10 UTC

[GitHub] incubator-weex pull request #534: * [ios] fix keep-scroll-position crash

GitHub user cxfeng1 opened a pull request:

    https://github.com/apache/incubator-weex/pull/534

    * [ios] fix keep-scroll-position crash

    demo:  http://dotwe.org/vue/62c15f7750d600aa5a184a3ca77c1e13
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cxfeng1/incubator-weex 0.16-dev

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/534.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #534
    
----
commit b56bd28aedbee5831e8d24bf239b993998e3c936
Author: yinfeng <cx...@apache.org>
Date:   2017-07-26T02:57:53Z

    * [ios] fix keep-scroll-position crash, demo:  http://dotwe.org/vue/62c15f7750d600aa5a184a3ca77c1e13

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #534: * [ios] fix keep-scroll-position crash

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/534
  
    
    <!--
      1 failure:  This PR modify SD...
      2 warning:  No Changelog chan..., This PR should up...
      
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      </tbody>
    </table>
    
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #534: * [ios] fix keep-scroll-position crash

Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 closed the pull request at:

    https://github.com/apache/incubator-weex/pull/534


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---