[GitHub] [rocketmq] socutes commented on a diff in pull request #6271: ReceiptHandleProcessor message renewal strategy optimization

["socutes (via GitHub)" <gi...@apache.org>]

socutes commented on code in PR #6271:
URL: https://github.com/apache/rocketmq/pull/6271#discussion_r1131104870


##########
proxy/src/main/java/org/apache/rocketmq/proxy/processor/ReceiptHandleProcessor.java:
##########
@@ -192,7 +193,7 @@ protected CompletableFuture<MessageReceiptHandle> startRenewMessage(MessageRecei
                         messageReceiptHandle.resetRenewRetryTimes();
                         resFuture.complete(messageReceiptHandle);
                     } else {
-                        log.error("renew response is not ok. result:{}, handle:{}", ackResult, messageReceiptHandle, throwable);
+                        log.error("renew response is not ok. result:{}", ackResult, messageReceiptHandle);

Review Comment:
   > The throwable argument is missing for log.error
   
   In this judgment condition, the throwable is always empty, so no record is required.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org