You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by tr...@apache.org on 2017/10/16 03:59:41 UTC
mac commit: CB-13449 Added support for 1024x1024 app icon
Repository: cordova-osx
Updated Branches:
refs/heads/master 5b8c0b577 -> e663fde25
CB-13449 Added support for 1024x1024 app icon
Project: http://git-wip-us.apache.org/repos/asf/cordova-osx/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-osx/commit/e663fde2
Tree: http://git-wip-us.apache.org/repos/asf/cordova-osx/tree/e663fde2
Diff: http://git-wip-us.apache.org/repos/asf/cordova-osx/diff/e663fde2
Branch: refs/heads/master
Commit: e663fde2523f8fde0ff97c784f42bccdb9c3f139
Parents: 5b8c0b5
Author: giuseppelt <gi...@users.noreply.github.com>
Authored: Sun Oct 15 01:18:48 2017 +0200
Committer: Tobias Bocanegra <tr...@adobe.com>
Committed: Mon Oct 16 12:58:35 2017 +0900
----------------------------------------------------------------------
bin/templates/scripts/cordova/lib/prepare.js | 1 +
tests/cdv-test-project/config.xml | 1 +
tests/spec/platform.spec.js | 3 ++-
3 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-osx/blob/e663fde2/bin/templates/scripts/cordova/lib/prepare.js
----------------------------------------------------------------------
diff --git a/bin/templates/scripts/cordova/lib/prepare.js b/bin/templates/scripts/cordova/lib/prepare.js
index 636492b..13f1c28 100644
--- a/bin/templates/scripts/cordova/lib/prepare.js
+++ b/bin/templates/scripts/cordova/lib/prepare.js
@@ -213,6 +213,7 @@ function handleIcons (projectConfig, platformRoot) {
// See https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/Designing.html
// for application images sizes reference.
var platformIcons = [
+ {dest: 'icon-1024x1024.png', width: 1024, height: 1024},
{dest: 'icon-512x512.png', width: 512, height: 512},
{dest: 'icon-256x256.png', width: 256, height: 256},
{dest: 'icon-128x128.png', width: 128, height: 128},
http://git-wip-us.apache.org/repos/asf/cordova-osx/blob/e663fde2/tests/cdv-test-project/config.xml
----------------------------------------------------------------------
diff --git a/tests/cdv-test-project/config.xml b/tests/cdv-test-project/config.xml
index d3a8bc4..9267a64 100644
--- a/tests/cdv-test-project/config.xml
+++ b/tests/cdv-test-project/config.xml
@@ -33,6 +33,7 @@
<icon src="res/test-64x64.png" width="128" height="128" />
<icon src="res/test-64x64.png" width="256" height="256" />
<icon src="res/test-64x64.png" width="512" height="512" />
+ <icon src="res/test-64x64.png" width="1024" height="1024" />
</platform>
</widget>
http://git-wip-us.apache.org/repos/asf/cordova-osx/blob/e663fde2/tests/spec/platform.spec.js
----------------------------------------------------------------------
diff --git a/tests/spec/platform.spec.js b/tests/spec/platform.spec.js
index 5738f34..581b052 100644
--- a/tests/spec/platform.spec.js
+++ b/tests/spec/platform.spec.js
@@ -60,7 +60,8 @@ describe('platform add', function() {
{name: 'icon-64x64.png', width: 64, height: 64},
{name: 'icon-128x128.png', width: 128, height: 128},
{name: 'icon-256x256.png', width: 256, height: 256},
- {name: 'icon-512x512.png', width: 512, height: 512}
+ {name: 'icon-512x512.png', width: 512, height: 512},
+ {name: 'icon-1024x1024.png', width: 1024, height: 1024}
];
var appIconsPath = path.join(test_platformPath, 'HelloCordova','Images.xcassets','AppIcon.appiconset');
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org