You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shenyu.apache.org by zcq <zc...@zhucongqi.cn> on 2021/09/07 00:08:35 UTC

New Fetatures Discussion

Hi bros:


Recently, I provides three&nbsp;features : custom the sign plugin signer, request id plugin and detect real error codes instead of all using 500.


There are two options for sign plugin,&nbsp;one is custom the SignService, another is custom&nbsp;the Signer.&nbsp; Custom the signer is just replace the "org.apache.shenyu.common.utils.SignUtils#generateSign", user can use another algorithm, such as sha1, sha256 etc.



see : https://github.com/apache/incubator-shenyu/pull/2021


The request id plugin will generate a id for every request. the id will put to request header and response header, so the downstream can fetch request id from request header, the frontend can fetch request id from response header. use the org.apache.shenyu.plugin.api.request.id.ShenyuRequestIdWrap#getRequestId API at any time to get the request id anywhere in the application.


request id plugin and detect real error codes see:&nbsp;https://github.com/apache/incubator-shenyu/pull/2027


How about the features?


thanks.

Re: New Fetatures Discussion

Posted by XiaoYu <xi...@apache.org>.
Hi

1. The signer maybe a good idea? But Can you give it a good name?  such as
SignAlgorithm?
2.  The  request id plugin Is there really a need for it to exist? To be
generated for every request? Can users turn it off dynamically?


zcq <zc...@zhucongqi.cn> 于2021年9月7日周二 上午8:08写道:

> Hi bros:
>
>
> Recently, I provides three&nbsp;features : custom the sign plugin signer,
> request id plugin and detect real error codes instead of all using 500.
>
>
> There are two options for sign plugin,&nbsp;one is custom the SignService,
> another is custom&nbsp;the Signer.&nbsp; Custom the signer is just replace
> the "org.apache.shenyu.common.utils.SignUtils#generateSign", user can use
> another algorithm, such as sha1, sha256 etc.
>
>
>
> see : https://github.com/apache/incubator-shenyu/pull/2021
>
>
> The request id plugin will generate a id for every request. the id will
> put to request header and response header, so the downstream can fetch
> request id from request header, the frontend can fetch request id from
> response header. use the org.apache.shenyu.plugin.api.request.id.ShenyuRequestIdWrap#getRequestId
> API at any time to get the request id anywhere in the application.
>
>
> request id plugin and detect real error codes see:&nbsp;
> https://github.com/apache/incubator-shenyu/pull/2027
>
>
> How about the features?
>
>
> thanks.

Re: New Fetatures Discussion

Posted by 张磊 <sa...@apache.org>.
Goog, I think plugin should be more expansibility


zcq <zc...@zhucongqi.cn> 于2021年9月7日周二 上午8:08写道:

> Hi bros:
>
>
> Recently, I provides three&nbsp;features : custom the sign plugin signer,
> request id plugin and detect real error codes instead of all using 500.
>
>
> There are two options for sign plugin,&nbsp;one is custom the SignService,
> another is custom&nbsp;the Signer.&nbsp; Custom the signer is just replace
> the "org.apache.shenyu.common.utils.SignUtils#generateSign", user can use
> another algorithm, such as sha1, sha256 etc.
>
>
>
> see : https://github.com/apache/incubator-shenyu/pull/2021
>
>
> The request id plugin will generate a id for every request. the id will
> put to request header and response header, so the downstream can fetch
> request id from request header, the frontend can fetch request id from
> response header. use the org.apache.shenyu.plugin.api.request.id.ShenyuRequestIdWrap#getRequestId
> API at any time to get the request id anywhere in the application.
>
>
> request id plugin and detect real error codes see:&nbsp;
> https://github.com/apache/incubator-shenyu/pull/2027
>
>
> How about the features?
>
>
> thanks.