[GitHub] [storm] srdo commented on a change in pull request #2981: Issue tracker [STORM-3362] Solved: eventHubSpout uses a blocking receiver in nextTuple()

[GitBox <gi...@apache.org>]

srdo commented on a change in pull request #2981: Issue tracker [STORM-3362] Solved: eventHubSpout uses a blocking receiver in nextTuple()
URL: https://github.com/apache/storm/pull/2981#discussion_r270059635
 
 

 ##########
 File path: external/storm-eventhubs/src/main/java/org/apache/storm/eventhubs/spout/EventHubSpoutConfig.java
 ##########
 @@ -42,6 +42,7 @@
     // disabling filter
     private String connectionString;
     private String topologyName;
+    private int receiverTimeoutInMillis = 10; // default
 
 Review comment:
   I'm not familiar with the EH client library, so I don't know if it fetches data in a background thread, but assuming it only fetches data when polled, latency to EH will be a concern. With a default of 100ms, you will only be able to fetch data at all if the latency is less than 100ms.
   
   The Kafka spout uses 200ms by default, but Kafka can be run "near" the spout (in network hops terms, e.g. in the same LAN), while EH is a hosted service. It might be good to set it conservatively, e.g. to 500-1000ms, and let people fine tune it manually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services