[GitHub] [cordova-electron] erisu commented on a change in pull request #156: refactor: remove more platform-centered code and files

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #156:
URL: https://github.com/apache/cordova-electron/pull/156#discussion_r455204018



##########
File path: tests/spec/unit/lib/Api.spec.js
##########
@@ -95,6 +95,15 @@ describe('Api class', () => {
             expect(api.root).toEqual(testProjectDir);
             expect(api.locations).toEqual(jasmine.objectContaining(mockExpectedLocations));
         });
+
+        it('should throw error when the constructor is missing platformRootDir argument.', () => {
+            expect(() => new Api()).toThrowError(CordovaError, 'The path to the platform root directory was undefined or invalid.');

Review comment:
       I applied your suggestions manually.
   
   Also the settings you used on the prettier seemed to be all default. It uses double quotes when we use single quotes.
   I went ahead made sure it was single quotes during the manual change.
   
   I tend to keep things on one line, but i'll try to be more cautious on the length of the line.
   
   Thanks for the review.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org