You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/12/08 19:40:10 UTC
[kudu-CR] Fix linked list-test flakiness
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5424
Change subject: Fix linked_list-test flakiness
......................................................................
Fix linked_list-test flakiness
A recent patch changed this test to do a snapshot scan at the end
which is now failing with a timeout. That patch looped this test
a bunch but, apparently, jenkins is even more stressful than
--stress_cpu_threads=4. I re-looped the test with --stress_cpu_theads=8
and observed 8/1000 failures.
The fix is to increase the timeout. After I did that I looped the
tests again and 1000/1000 passed.
Config:
KUDU_ALLOW_SLOW_TESTS=1 ../../build-support/dist_test.py loop -n 1000 \
bin/linked_list-test --stress_cpu_threads=8 --gtest_filter=*TestLoadAndVerify*
Results:
http://dist-test.cloudera.org//job?job_id=david.alves.1481225032.13214
Change-Id: Ice3d92e8112fc336d24600d6d817e37729ff8467
---
M src/kudu/integration-tests/linked_list-test-util.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/5424/1
--
To view, visit http://gerrit.cloudera.org:8080/5424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice3d92e8112fc336d24600d6d817e37729ff8467
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Fix linked list-test flakiness
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Fix linked_list-test flakiness
......................................................................
Fix linked_list-test flakiness
A recent patch changed this test to do a snapshot scan at the end
which is now failing with a timeout. That patch looped this test
a bunch but, apparently, jenkins is even more stressful than
--stress_cpu_threads=4. I re-looped the test with --stress_cpu_theads=8
and observed 8/1000 failures.
The fix is to increase the timeout. After I did that I looped the
tests again and 1000/1000 passed.
Config:
KUDU_ALLOW_SLOW_TESTS=1 ../../build-support/dist_test.py loop -n 1000 \
bin/linked_list-test --stress_cpu_threads=8 --gtest_filter=*TestLoadAndVerify*
Results:
http://dist-test.cloudera.org//job?job_id=david.alves.1481225032.13214
Change-Id: Ice3d92e8112fc336d24600d6d817e37729ff8467
Reviewed-on: http://gerrit.cloudera.org:8080/5424
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/linked_list-test-util.h
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice3d92e8112fc336d24600d6d817e37729ff8467
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix linked list-test flakiness
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Fix linked_list-test flakiness
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice3d92e8112fc336d24600d6d817e37729ff8467
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix linked list-test flakiness
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Fix linked_list-test flakiness
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5424
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice3d92e8112fc336d24600d6d817e37729ff8467
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No