You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/24 14:21:50 UTC

[GitHub] [superset] geido commented on a change in pull request #13736: test: DataTablesPane

geido commented on a change in pull request #13736:
URL: https://github.com/apache/superset/pull/13736#discussion_r600522850



##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -255,7 +255,7 @@ export const DataTablesPane = ({
   };
 
   return (
-    <SouthPane>
+    <SouthPane data-test="DataTablesPane">

Review comment:
       Super small nit. I think I have seen a pretty adopted convention for the `data-test` to be hyphen separated or just lower case




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org