You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ramkrish86 <gi...@git.apache.org> on 2016/03/21 17:36:20 UTC
[GitHub] flink pull request: [FLINK-3631] CodeGenerator does not check type...
GitHub user ramkrish86 opened a pull request:
https://github.com/apache/flink/pull/1823
[FLINK-3631] CodeGenerator does not check type compatibility for equa…
Adds a check on the CodeGenerator.scala code which does a check on the left and right operands so that all the comparison expressions can work now. (=,!=,>,<)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramkrish86/flink FLINK-3631
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1823
----
commit d107f4825d40998b9e40a5270b8df48dd48b8eb2
Author: ramkrishna <ra...@gmail.com>
Date: 2016-03-21T16:33:42Z
[FLINK-3631] CodeGenerator does not check type compatibility for equality
expressions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3631] CodeGenerator does not check type...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1823#issuecomment-199506835
Thanks for the PR @ramkrish86
Looks good. Just one minor thing. Can you add a one line comment to each test that explains why the program should fail such as the tests `testNonWorkingSubstring1()` and `testNonWorkingSubstring2()`? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3631] CodeGenerator does not check type...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1823#issuecomment-199717085
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3631] CodeGenerator does not check type...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1823
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3631] CodeGenerator does not check type...
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the pull request:
https://github.com/apache/flink/pull/1823#issuecomment-199641069
I have done the update @fhueske .Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3631] CodeGenerator does not check type...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1823#issuecomment-199686918
Perfect, thanks for the update. Good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---