You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/11 16:10:29 UTC
[GitHub] [arrow-datafusion] kmitchener opened a new pull request, #3447: add `cast` support inside `values`
kmitchener opened a new pull request, #3447:
URL: https://github.com/apache/arrow-datafusion/pull/3447
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3446 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #3447: add `cast` support inside `values`
Posted by GitBox <gi...@apache.org>.
Dandandan merged PR #3447:
URL: https://github.com/apache/arrow-datafusion/pull/3447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] kmitchener commented on pull request #3447: add `cast` support inside `values`
Posted by GitBox <gi...@apache.org>.
kmitchener commented on PR #3447:
URL: https://github.com/apache/arrow-datafusion/pull/3447#issuecomment-1243891031
> Looks good @kmitchener 👍 thank you
>
> Looking at this code, I wonder why there are special cases for Expr values at all in the sql planner. It seems like this is a special case of expression coercion (aka we are trying to coerce / cast all arguments to the same type).
Hmm, do you mean that maybe we can set some rules about which exprs are valid and use those to filter the input to values() rather than explicitly listing which expressions are valid? It does seem like there should be a better way to do this, because values() can take most (any?) expression that's not aggregate, like substring or case or even try_cast for that matter .. maybe a follow-on issue for that? that's beyond me at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3447: add `cast` support inside `values`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3447:
URL: https://github.com/apache/arrow-datafusion/pull/3447#issuecomment-1243956464
Benchmark runs are scheduled for baseline = c5c1dae36b45b27bec27cf42862aa5ce32e0d6b5 and contender = 3e56a0f773a812c7bed760d44497b586a3db1872. 3e56a0f773a812c7bed760d44497b586a3db1872 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/83733aaea8a643218fb94cb9390f7b4d...4457455672394462ab54e2190cfb6c99/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a3daf6e9b20a4190b99a3ad4594381c8...729ab5ec652c4cc8bc210b3b9fa06c49/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/cedceade46af49a6bbc9c9c3d668990e...12f5989cffb949e5bef2782f1825bca6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4a033669b54b4160ba1f077d3ffb4713...05ca3a1478ad46c9be4341820159d6f3/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3447: add `cast` support inside `values`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3447:
URL: https://github.com/apache/arrow-datafusion/pull/3447#issuecomment-1244040060
> Hmm, do you mean that maybe we can set some rules about which exprs are valid and use those to filter the input to values() rather than explicitly listing which expressions are valid? It does seem like there should be a better way to do this, because values() can take most (any?) expression that's not aggregate, like substring or case or even try_cast for that matter ..
Yes, exactly this.
> maybe a follow-on issue for that? that's beyond me at the moment.
I will do so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3447: add `cast` support inside `values`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3447:
URL: https://github.com/apache/arrow-datafusion/pull/3447#issuecomment-1243000262
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3447?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3447](https://codecov.io/gh/apache/arrow-datafusion/pull/3447?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b7ed1c0) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/8df5496ce77638e57bde8468801e78d61e423d92?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8df5496) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #3447 +/- ##
==========================================
- Coverage 85.69% 85.69% -0.01%
==========================================
Files 298 298
Lines 54644 54658 +14
==========================================
+ Hits 46826 46837 +11
- Misses 7818 7821 +3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3447?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/core/tests/sql/select.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3447/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3Rlc3RzL3NxbC9zZWxlY3QucnM=) | `99.78% <100.00%> (+<0.01%)` | :arrow_up: |
| [datafusion/sql/src/planner.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3447/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9zcWwvc3JjL3BsYW5uZXIucnM=) | `80.94% <100.00%> (+0.05%)` | :arrow_up: |
| [datafusion/expr/src/window\_frame.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3447/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy93aW5kb3dfZnJhbWUucnM=) | `92.43% <0.00%> (-0.85%)` | :arrow_down: |
| [datafusion/core/src/physical\_plan/metrics/value.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3447/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL21ldHJpY3MvdmFsdWUucnM=) | `86.93% <0.00%> (-0.51%)` | :arrow_down: |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3447/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.19% <0.00%> (-0.17%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org