You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "Ash Berlin-Taylor (JIRA)" <ji...@apache.org> on 2019/06/05 12:30:00 UTC

[jira] [Commented] (AIRFLOW-4734) Upsert functionality for PostgresHook.insert_rows()

    [ https://issues.apache.org/jira/browse/AIRFLOW-4734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856666#comment-16856666 ] 

Ash Berlin-Taylor commented on AIRFLOW-4734:
--------------------------------------------

Sounds good.

> Upsert functionality for PostgresHook.insert_rows()
> ---------------------------------------------------
>
>                 Key: AIRFLOW-4734
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4734
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>    Affects Versions: 1.10.3
>            Reporter: William Tran
>            Assignee: William Tran
>            Priority: Minor
>              Labels: features
>             Fix For: 1.10.4
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> PostgresHook's parent class, DbApiHook, implements upsert in its insert_rows() method with the replace=True flag. However, the underlying generated SQL is specific to MySQL's "REPLACE INTO" syntax and is not applicable to Postgres.
> I'd like to override this method in PostgresHook to implement the "INSERT ... ON CONFLICT DO UPDATE" syntax (new since Postgres 9.5)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)