You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <hu...@gmail.com> on 2016/03/01 01:48:50 UTC
Review Request 44193: GEODe-562 and changes to clean up some gradle
dependencies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44193/
-----------------------------------------------------------
Review request for geode, Anthony Baker, anilkumar gingade, Barry Oglesby, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
Moved some of the dependencies from the common java.gradle to the sub projects that actually used these dependencies.
Modified some of the scopes for the dependencies
I made a mistake and accidently checked in the actual fix for GEODE-562 in an unrelated test fix commit a while back, so that is why you won't actually see the gradle/dependency-version.properties change here. I'll be sure to update the ticket with the actual commit that it snuck into.
There are quite a few dependencies that are used in a class or two that possibly can either be moved/removed or modified but those should probably specified directly and be seperate taskes in themselves.
Diffs
-----
extensions/geode-modules/build.gradle f96fde6
geode-core/build.gradle 1aa07ee
geode-pulse/build.gradle 0cd1ef4
geode-rebalancer/build.gradle 9efdff2
gradle/java.gradle 06fb766
Diff: https://reviews.apache.org/r/44193/diff/
Testing
-------
running precheckin
suggestions for any tests that should be run?
Thanks,
Jason Huynh
Re: Review Request 44193: GEODe-562 and changes to clean up some
gradle dependencies
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44193/#review121510
-----------------------------------------------------------
Ship it!
Seems like a good incremental improvement!
- Dan Smith
On March 1, 2016, 12:48 a.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44193/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 12:48 a.m.)
>
>
> Review request for geode, Anthony Baker, anilkumar gingade, Barry Oglesby, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Moved some of the dependencies from the common java.gradle to the sub projects that actually used these dependencies.
> Modified some of the scopes for the dependencies
>
> I made a mistake and accidently checked in the actual fix for GEODE-562 in an unrelated test fix commit a while back, so that is why you won't actually see the gradle/dependency-version.properties change here. I'll be sure to update the ticket with the actual commit that it snuck into.
>
> There are quite a few dependencies that are used in a class or two that possibly can either be moved/removed or modified but those should probably specified directly and be seperate taskes in themselves.
>
>
> Diffs
> -----
>
> extensions/geode-modules/build.gradle f96fde6
> geode-core/build.gradle 1aa07ee
> geode-pulse/build.gradle 0cd1ef4
> geode-rebalancer/build.gradle 9efdff2
> gradle/java.gradle 06fb766
>
> Diff: https://reviews.apache.org/r/44193/diff/
>
>
> Testing
> -------
>
> running precheckin
>
> suggestions for any tests that should be run?
>
>
> Thanks,
>
> Jason Huynh
>
>
Re: Review Request 44193: GEODe-562 and changes to clean up some
gradle dependencies
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44193/#review121536
-----------------------------------------------------------
Ship it!
I am in line with making dependencies more definitive per project and it will help clean up our Maven distribution in the long run.
- Mark Bretl
On Feb. 29, 2016, 4:48 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44193/
> -----------------------------------------------------------
>
> (Updated Feb. 29, 2016, 4:48 p.m.)
>
>
> Review request for geode, Anthony Baker, anilkumar gingade, Barry Oglesby, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Moved some of the dependencies from the common java.gradle to the sub projects that actually used these dependencies.
> Modified some of the scopes for the dependencies
>
> I made a mistake and accidently checked in the actual fix for GEODE-562 in an unrelated test fix commit a while back, so that is why you won't actually see the gradle/dependency-version.properties change here. I'll be sure to update the ticket with the actual commit that it snuck into.
>
> There are quite a few dependencies that are used in a class or two that possibly can either be moved/removed or modified but those should probably specified directly and be seperate taskes in themselves.
>
>
> Diffs
> -----
>
> extensions/geode-modules/build.gradle f96fde6
> geode-core/build.gradle 1aa07ee
> geode-pulse/build.gradle 0cd1ef4
> geode-rebalancer/build.gradle 9efdff2
> gradle/java.gradle 06fb766
>
> Diff: https://reviews.apache.org/r/44193/diff/
>
>
> Testing
> -------
>
> running precheckin
>
> suggestions for any tests that should be run?
>
>
> Thanks,
>
> Jason Huynh
>
>