[GitHub] [incubator-mxnet] anirudh2290 commented on a change in pull request #14451: fix custom operation in fork

[GitBox <gi...@apache.org>]

anirudh2290 commented on a change in pull request #14451: fix custom operation in fork
URL: https://github.com/apache/incubator-mxnet/pull/14451#discussion_r266244339
 
 

 ##########
 File path: src/initialize.cc
 ##########
 @@ -53,11 +54,14 @@ class LibraryInitializer {
 
 // disable openmp for multithreaded workers
 #ifndef _WIN32
+    using op::custom::CustomOperator;
     pthread_atfork(
       []() {
+        CustomOperator::Get()->Stop();
         Engine::Get()->Stop();
 
 Review comment:
   can we call Engine stop before customop stop. This will ensure that all ops pushed to engine have executed before stopping engine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services