[GitHub] [iceberg] dilipbiswal commented on a change in pull request #1947: [WIP] Spark MERGE INTO Support (copy-on-write implementation)

[GitBox <gi...@apache.org>]

dilipbiswal commented on a change in pull request #1947:
URL: https://github.com/apache/iceberg/pull/1947#discussion_r545980383



##########
File path: spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/MergeInto.scala
##########
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.spark.sql.catalyst.plans.logical
+
+import org.apache.spark.sql.Row
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder
+import org.apache.spark.sql.catalyst.expressions._
+import org.apache.spark.sql.catalyst.expressions.codegen.GeneratePredicate
+import org.apache.spark.sql.execution.datasources.v2.DataSourceV2Relation
+import org.apache.spark.sql.functions.col
+
+case class MergeInto(mergeIntoProcessor: MergeIntoProcessor,
+                     targetRelation: DataSourceV2Relation,
+                     child: LogicalPlan) extends UnaryNode {
+  override def output: Seq[Attribute] = targetRelation.output
+}
+
+class MergeIntoProcessor(isSourceRowNotPresent: Expression,
+                         isTargetRowNotPresent: Expression,
+                         matchedConditions: Seq[Expression],
+                         matchedOutputs: Seq[Seq[Expression]],
+                         notMatchedConditions: Seq[Expression],
+                         notMatchedOutputs: Seq[Seq[Expression]],
+                         targetOutput: Seq[Expression],
+                         joinedAttributes: Seq[Attribute]) extends Serializable {

Review comment:
       @rdblue Can you please explain the idea bit more, specifically the `should be broken up into analysis rules to validate and update `MergeInto` plan` . Currently, we produce the `MergeInto` logical plan in the optimizer phase ? So we have gone past analysis at this point right ? The input SQL has already been parsed and resolved using `MergeIntoTable` by spark at this point i.e all the `mergeinto` inputs have been resolved ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org