You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:53:30 UTC
[GitHub] [arrow] ZMZ91 opened a new pull request #7846: ARROW-8445: [Gandiva][UDF] Add a udf for gandiva to extract all named groups.
ZMZ91 opened a new pull request #7846:
URL: https://github.com/apache/arrow/pull/7846
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7846: ARROW-8445: [Gandiva][UDF][c++] Add a udf for gandiva to extract all named groups.
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7846:
URL: https://github.com/apache/arrow/pull/7846#issuecomment-667785504
@praveenbingo do you have time to review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ZMZ91 closed pull request #7846: ARROW-8445: [Gandiva][UDF][c++] Add a udf for gandiva to extract all named groups.
Posted by GitBox <gi...@apache.org>.
ZMZ91 closed pull request #7846:
URL: https://github.com/apache/arrow/pull/7846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7846: ARROW-8445: [Gandiva][UDF][c++] Add a udf for gandiva to extract all named groups.
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7846:
URL: https://github.com/apache/arrow/pull/7846#issuecomment-691820492
@ZMZ91 sorry for the delay. The lint failure is:
> cd /tmp/arrow-lint-kcallphf/cpp-build && /usr/local/bin/python /arrow/cpp/build-support/lint_cpp_cli.py /arrow/cpp/src
File /arrow/cpp/src/gandiva/rex_holder.h failed C++/CLI lint check: Uses nullptr
Line 56: literal == nullptr,
You need to use NULLPTR in header files.
For the Java error, I'm not exactly sure what is going on, but I think this i the first instance of trying to use a nested type in Gandiva (the type mapping of i8_ptr_type looks wrong to me). I think you might want to discuss this PR on the mailing list first as there might be some difficulties here (I'm not an expert on Gandiva).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7846: ARROW-8445: [Gandiva][UDF] Add a udf for gandiva to extract all named groups.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7846:
URL: https://github.com/apache/arrow/pull/7846#issuecomment-664743773
https://issues.apache.org/jira/browse/ARROW-8445
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ZMZ91 commented on pull request #7846: ARROW-8445: [Gandiva][UDF][c++] Add a udf for gandiva to extract all named groups.
Posted by GitBox <gi...@apache.org>.
ZMZ91 commented on pull request #7846:
URL: https://github.com/apache/arrow/pull/7846#issuecomment-665403760
Hi, could someone help review this pr and check the failures? Thanks in advance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org