You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pekko.apache.org by fa...@apache.org on 2023/06/11 11:20:40 UTC
[incubator-pekko-connectors] branch scala3 updated: enable scala3 build for more google connectors (#165)
This is an automated email from the ASF dual-hosted git repository.
fanningpj pushed a commit to branch scala3
in repository https://gitbox.apache.org/repos/asf/incubator-pekko-connectors.git
The following commit(s) were added to refs/heads/scala3 by this push:
new 310479c6b enable scala3 build for more google connectors (#165)
310479c6b is described below
commit 310479c6b7079294e9f513579877e6979c5c94ed
Author: PJ Fanning <pj...@users.noreply.github.com>
AuthorDate: Sun Jun 11 12:20:34 2023 +0100
enable scala3 build for more google connectors (#165)
* enable scala3 build for more google connectors
* implicits
* disable part of scala3 build
* try full build again
* Update GooglePubSub.scala
* refactor suggested by @mdedetrich
* remove interim variables
* add comments
* Update GooglePubSub.scala
---
.../googlecloud/pubsub/grpc/javadsl/GooglePubSub.scala | 12 ++++++++++--
.../googlecloud/pubsub/grpc/javadsl/GrpcPublisher.scala | 2 +-
.../googlecloud/pubsub/grpc/javadsl/GrpcSubscriber.scala | 2 +-
.../googlecloud/pubsub/grpc/scaladsl/GrpcPublisher.scala | 2 +-
.../googlecloud/pubsub/grpc/scaladsl/GrpcSubscriber.scala | 2 +-
.../src/test/scala/docs/scaladsl/IntegrationSpec.scala | 2 +-
.../pekko/stream/connectors/google/ResumableUpload.scala | 1 -
project/Dependencies.scala | 2 --
8 files changed, 15 insertions(+), 10 deletions(-)
diff --git a/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GooglePubSub.scala b/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GooglePubSub.scala
index e5f3015a6..1dc65054a 100644
--- a/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GooglePubSub.scala
+++ b/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GooglePubSub.scala
@@ -69,7 +69,11 @@ object GooglePubSub {
Source
.tick(Duration.ZERO, pollInterval, subsequentRequest)
.mapMaterializedValue(cancellable.complete(_))))
- .mapConcat(_.getReceivedMessagesList)
+ .mapConcat(
+ // TODO uptake any fix suggested for https://contributors.scala-lang.org/t/better-type-inference-for-scala-send-us-your-problematic-cases/2410/183
+ ((response: StreamingPullResponse) =>
+ response.getReceivedMessagesList): pekko.japi.function.Function[StreamingPullResponse,
+ java.util.List[ReceivedMessage]])
.mapMaterializedValue(_ => cancellable)
}
.mapMaterializedValue(flattenCs(_))
@@ -95,7 +99,11 @@ object GooglePubSub {
Source
.tick(Duration.ZERO, pollInterval, request)
.mapAsync(1, client.pull(_))
- .mapConcat(_.getReceivedMessagesList)
+ .mapConcat(
+ // TODO uptake any fix suggested for https://contributors.scala-lang.org/t/better-type-inference-for-scala-send-us-your-problematic-cases/2410/183
+ ((response: PullResponse) =>
+ response.getReceivedMessagesList): pekko.japi.function.Function[PullResponse,
+ java.util.List[ReceivedMessage]])
.mapMaterializedValue(cancellable.complete(_))
.mapMaterializedValue(_ => cancellable)
}
diff --git a/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GrpcPublisher.scala b/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GrpcPublisher.scala
index b36fd9cf6..7912626a5 100644
--- a/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GrpcPublisher.scala
+++ b/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GrpcPublisher.scala
@@ -74,7 +74,7 @@ object GrpcPublisher {
* An extension that manages a single gRPC java publisher client per actor system.
*/
final class GrpcPublisherExt private (sys: ExtendedActorSystem) extends Extension {
- implicit val publisher = GrpcPublisher.create(sys)
+ implicit val publisher: GrpcPublisher = GrpcPublisher.create(sys)
}
object GrpcPublisherExt extends ExtensionId[GrpcPublisherExt] with ExtensionIdProvider {
diff --git a/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GrpcSubscriber.scala b/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GrpcSubscriber.scala
index 3286f8859..5d24fc2bb 100644
--- a/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GrpcSubscriber.scala
+++ b/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/javadsl/GrpcSubscriber.scala
@@ -75,7 +75,7 @@ object GrpcSubscriber {
* An extension that manages a single gRPC java subscriber client per actor system.
*/
final class GrpcSubscriberExt private (sys: ExtendedActorSystem) extends Extension {
- implicit val subscriber = GrpcSubscriber.create(sys)
+ implicit val subscriber: GrpcSubscriber = GrpcSubscriber.create(sys)
}
object GrpcSubscriberExt extends ExtensionId[GrpcSubscriberExt] with ExtensionIdProvider {
diff --git a/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/scaladsl/GrpcPublisher.scala b/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/scaladsl/GrpcPublisher.scala
index 799019fc2..b6a14e9b2 100644
--- a/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/scaladsl/GrpcPublisher.scala
+++ b/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/scaladsl/GrpcPublisher.scala
@@ -65,7 +65,7 @@ object GrpcPublisher {
* An extension that manages a single gRPC scala publisher client per actor system.
*/
final class GrpcPublisherExt private (sys: ExtendedActorSystem) extends Extension {
- implicit val publisher = GrpcPublisher(sys: ActorSystem)
+ implicit val publisher: GrpcPublisher = GrpcPublisher(sys: ActorSystem)
}
object GrpcPublisherExt extends ExtensionId[GrpcPublisherExt] with ExtensionIdProvider {
diff --git a/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/scaladsl/GrpcSubscriber.scala b/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/scaladsl/GrpcSubscriber.scala
index 87fdef615..65b29c409 100644
--- a/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/scaladsl/GrpcSubscriber.scala
+++ b/google-cloud-pub-sub-grpc/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/pubsub/grpc/scaladsl/GrpcSubscriber.scala
@@ -65,7 +65,7 @@ object GrpcSubscriber {
* An extension that manages a single gRPC scala subscriber client per actor system.
*/
final class GrpcSubscriberExt private (sys: ExtendedActorSystem) extends Extension {
- implicit val subscriber = GrpcSubscriber(sys: ActorSystem)
+ implicit val subscriber: GrpcSubscriber = GrpcSubscriber(sys: ActorSystem)
}
object GrpcSubscriberExt extends ExtensionId[GrpcSubscriberExt] with ExtensionIdProvider {
diff --git a/google-cloud-pub-sub-grpc/src/test/scala/docs/scaladsl/IntegrationSpec.scala b/google-cloud-pub-sub-grpc/src/test/scala/docs/scaladsl/IntegrationSpec.scala
index c6616c520..badba9969 100644
--- a/google-cloud-pub-sub-grpc/src/test/scala/docs/scaladsl/IntegrationSpec.scala
+++ b/google-cloud-pub-sub-grpc/src/test/scala/docs/scaladsl/IntegrationSpec.scala
@@ -52,7 +52,7 @@ class IntegrationSpec
implicit val system: ActorSystem = ActorSystem("IntegrationSpec")
- implicit val defaultPatience = PatienceConfig(timeout = 15.seconds, interval = 50.millis)
+ implicit val defaultPatience: PatienceConfig = PatienceConfig(timeout = 15.seconds, interval = 50.millis)
"connector" should {
diff --git a/google-common/src/main/scala/org/apache/pekko/stream/connectors/google/ResumableUpload.scala b/google-common/src/main/scala/org/apache/pekko/stream/connectors/google/ResumableUpload.scala
index 81f9e7db6..71ac9641f 100644
--- a/google-common/src/main/scala/org/apache/pekko/stream/connectors/google/ResumableUpload.scala
+++ b/google-common/src/main/scala/org/apache/pekko/stream/connectors/google/ResumableUpload.scala
@@ -14,7 +14,6 @@
package org.apache.pekko.stream.connectors.google
import org.apache.pekko
-import pekko.actor.ActorSystem
import pekko.NotUsed
import pekko.annotation.InternalApi
import pekko.http.scaladsl.model.HttpMethods.{ POST, PUT }
diff --git a/project/Dependencies.scala b/project/Dependencies.scala
index 33258b47e..b22b1d2eb 100644
--- a/project/Dependencies.scala
+++ b/project/Dependencies.scala
@@ -217,7 +217,6 @@ object Dependencies {
"io.specto" % "hoverfly-java" % hoverflyVersion % Test // ApacheV2
) ++ Mockito)
val GoogleBigQueryStorage = Seq(
- crossScalaVersions -= Scala3,
// see Pekko gRPC version in plugins.sbt
libraryDependencies ++= Seq(
// https://github.com/googleapis/java-bigquerystorage/tree/master/proto-google-cloud-bigquerystorage-v1
@@ -240,7 +239,6 @@ object Dependencies {
) ++ Mockito)
val GooglePubSubGrpc = Seq(
- crossScalaVersions -= Scala3,
// see Pekko gRPC version in plugins.sbt
libraryDependencies ++= Seq(
// https://github.com/googleapis/java-pubsub/tree/master/proto-google-cloud-pubsub-v1/
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pekko.apache.org
For additional commands, e-mail: commits-help@pekko.apache.org