You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Gregory Shimansky (JIRA)" <ji...@apache.org> on 2006/12/26 01:10:23 UTC
[jira] Resolved: (HARMONY-2872) [drlvm][classloader] Improved class
file format parser
[ http://issues.apache.org/jira/browse/HARMONY-2872?page=all ]
Gregory Shimansky resolved HARMONY-2872.
----------------------------------------
Resolution: Fixed
Patch applied at 490202. Please check that it was applied as expected.
I didn't understand however what exactly the attached test actually tests. It gives the same results with and without patch and they are equal to what RI prints. The only difference I saw is when after I applied the patch VM started to support -Xinvisible and printed out 2 invisible methods. Is it the whole purpose of this test?
> [drlvm][classloader] Improved class file format parser
> ------------------------------------------------------
>
> Key: HARMONY-2872
> URL: http://issues.apache.org/jira/browse/HARMONY-2872
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Vera Volynets
> Assigned To: Gregory Shimansky
> Attachments: Class_file_parser_improvements_20061225.patch, Test.java
>
>
> I suggest following improvements which I made to Class file parser.
> 1) Introduced new Tag CONSTANT_UnusedEntry. This tag is needed to detect reference from lcd2_w to second entry of double or long which shouldn't be used according to specification. If verifier is turned off, the second element will be treated as regular CONSTANT_Double or CONSTANT_Long.
> 2) Improved access flags parsing, reset flags which is used for Java 5.0 if class file has version less than 49.
> 3) Improved exception messages for several class format errors.
> 4) Made preparation for field and method name check depending on class file version.
> 5) Implemented parsing of RuntimeInvisibleAnnotations and RuntimeInvisibleParameterAnnotations attributes. Introduced new command line flag "-Xinvisible" to retain these annotations.
> 6) Add future changes to TODO list.
> 7) Checked UTF_8 string correctness
> Patch is attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira