You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/04 06:16:16 UTC

[GitHub] [ozone] umamaheswararao opened a new pull request, #3380: HDDS-6659: EC: Add BlockGroupLen info as part of PutBlock in EC Writes for helping in recovery.

umamaheswararao opened a new pull request, #3380:
URL: https://github.com/apache/ozone/pull/3380

   ## What changes were proposed in this pull request?
   
   Sending the current block group length on putblock call
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-6659
   
   ## How was this patch tested?
   
   Added test to verify.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] umamaheswararao merged pull request #3380: HDDS-6659: EC: Add BlockGroupLen info as part of PutBlock in EC Writes for helping in recovery.

Posted by GitBox <gi...@apache.org>.
umamaheswararao merged PR #3380:
URL: https://github.com/apache/ozone/pull/3380


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] guihecheng commented on pull request #3380: HDDS-6659: EC: Add BlockGroupLen info as part of PutBlock in EC Writes for helping in recovery.

Posted by GitBox <gi...@apache.org>.
guihecheng commented on PR #3380:
URL: https://github.com/apache/ozone/pull/3380#issuecomment-1120719966

   LGTM+1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] JacksonYao287 commented on pull request #3380: HDDS-6659: EC: Add BlockGroupLen info as part of PutBlock in EC Writes for helping in recovery.

Posted by GitBox <gi...@apache.org>.
JacksonYao287 commented on PR #3380:
URL: https://github.com/apache/ozone/pull/3380#issuecomment-1118606082

   thanks @umamaheswararao for the work , the change overall looks good to me.
   i am not quite sure do we really need this info. when reading chunks of the last stripe in a block group,  if the size of a chunk is less than chunksize, (index-1) * chunksize + currentChunkSize will be the last stripe data size , so that we can get the block group length.
   
   do you mean if the last partial chunk is just in the lost container, without the block group lengh, we can not identify with part of the recovered chunk is data, and which part is padding?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] umamaheswararao commented on pull request #3380: HDDS-6659: EC: Add BlockGroupLen info as part of PutBlock in EC Writes for helping in recovery.

Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on PR #3380:
URL: https://github.com/apache/ozone/pull/3380#issuecomment-1119827917

   Thanks @JacksonYao287 for the review.
   Yes, at the time of recovery, we don't have a group len information as that's only available with OM.
   We need this length information to make sure we are reading at the right boundaries, mainly to help figure out the correct partial stripe boundaries. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org