[GitHub] [incubator-tvm] altanh commented on a change in pull request #6851: [RELAY][OP] Support MXNet-style attributes for reshape_like

[GitBox <gi...@apache.org>]

altanh commented on a change in pull request #6851:
URL: https://github.com/apache/incubator-tvm/pull/6851#discussion_r518257417



##########
File path: src/relay/op/make_op.h
##########
@@ -62,6 +62,9 @@ Expr MakeRepeat(Expr data, int repeats, int axis);
 
 Expr MakeReshape(Expr data, Array<Integer> newshape);
 
+Expr MakeReshapeLike(Expr lhs, Expr rhs, int64_t lhs_begin, Integer lhs_end, int64_t rhs_begin,

Review comment:
       I did this because the beginning index (in both cases) must always be an integer, but the end index can be `None` which means I must use a nullable `Integer` wrapper. I could make everything `Integer` and check that beginning is always defined. I did feel a bit weird using `int64_t` directly since everything else seem to use `int` but the value wrapped by `Integer` is `int64_t` so that's why I chose it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org