Re: [PR] Add primitive_null metadata for example Variant values [parquet-testing]

["Fokko (via GitHub)" <gi...@apache.org>]

Fokko commented on code in PR #84:
URL: https://github.com/apache/parquet-testing/pull/84#discussion_r2101083007


##########
variant/README.md:
##########
@@ -45,8 +45,22 @@ Each example consists of 2 files:
 
 ## Regenerating these files
 
-The files were generated by running the [`regen.py`](regen.py) script that uses Apache Spark to 
-generate the files.
+The files in this directory were initially generated by running the [`regen.py`](regen.py) 
+script which used Apache Spark to generate the files. The files have been subsequently modified
+when necessary to ensure that they conform to the Parquet spec.
+
+### Modification 1: Created metadata for  `primitive_null` as a single byte (0x01) 

Review Comment:
   ```suggestion
   ### Modification 1: Created metadata for `primitive_null` as a single byte (`0x01`) 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org