You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by mureinik <gi...@git.apache.org> on 2017/02/22 08:38:51 UTC
[GitHub] commons-lang pull request #242: Fix FastDateParser#getStrategy(char, int, Ca...
GitHub user mureinik opened a pull request:
https://github.com/apache/commons-lang/pull/242
Fix FastDateParser#getStrategy(char, int, Calendar) javadoc
The javadoc refers to a `formatField` parameter, which the method doesn't
have.
Reading the description and the method's code, this documentation
clearly refers to the `f` parameter.
This patch fixes the javadoc and aligns it with the method's parameters.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mureinik/commons-lang FastDateParser-javadoc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #242
----
commit ce2a224f8e61ae9ceaa10de4e145ab95aa2f1170
Author: Allon Mureinik <am...@redhat.com>
Date: 2017-02-22T08:35:57Z
Fix FastDateParser#getStrategy(char, int, Calendar) javadoc
The javadoc refers to a formatField parameter, which the method doesn't
have.
Reading the description and the method's code, this documentation
clearly refers to the f parameter.
This patch fixes the javadoc and aligns it with the method's parameters.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request #242: Fix FastDateParser#getStrategy(char, int, Ca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/242
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #242: Fix FastDateParser#getStrategy(char, int, Calendar)...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/242
[](https://coveralls.io/builds/10281425)
Coverage increased (+0.04%) to 94.567% when pulling **ce2a224f8e61ae9ceaa10de4e145ab95aa2f1170 on mureinik:FastDateParser-javadoc** into **4bd982d1a1df87724682c17c39bf27b5cbe389be on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #242: Fix FastDateParser#getStrategy(char, int, Calendar)...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/242
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang issue #242: Fix FastDateParser#getStrategy(char, int, Calendar)...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-lang/pull/242
[](https://coveralls.io/builds/10281425)
Coverage increased (+0.04%) to 94.567% when pulling **ce2a224f8e61ae9ceaa10de4e145ab95aa2f1170 on mureinik:FastDateParser-javadoc** into **4bd982d1a1df87724682c17c39bf27b5cbe389be on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---