You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/06/29 23:42:00 UTC

[jira] [Work logged] (GOBBLIN-1208) Fix - restApiRetryLimit cannot be set to 0

     [ https://issues.apache.org/jira/browse/GOBBLIN-1208?focusedWorklogId=452700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-452700 ]

ASF GitHub Bot logged work on GOBBLIN-1208:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jun/20 23:41
            Start Date: 29/Jun/20 23:41
    Worklog Time Spent: 10m 
      Work Description: arekusuri opened a new pull request #3053:
URL: https://github.com/apache/incubator-gobblin/pull/3053


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   https://issues.apache.org/jira/browse/GOBBLIN-1208
   
   
   ### Description
   Fix - restApiRetryLimit cannot be set to 0
   if we set restApiRetryLimit=0, the code should be execute 1 time.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 452700)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix - restApiRetryLimit cannot be set to 0
> ------------------------------------------
>
>                 Key: GOBBLIN-1208
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1208
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Alex Li
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Fix - restApiRetryLimit cannot be set to 0
> if we set restApiRetryLimit=0, the code should be execute 1 time.
> change code:
> {code:java}
>   private JsonArray getRecordsForQuery(SalesforceConnector connector, String query) {
>     RestApiProcessingException exception = null;
>     for (int i = 0; i < workUnitConf.restApiRetryLimit; i++) {
> {code}
> to 
> {code:java}
>   private JsonArray getRecordsForQuery(SalesforceConnector connector, String query) { 
>     RestApiProcessingException exception = null; 
>     for (int i = 0; i < workUnitConf.restApiRetryLimit+1; i++) {
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)