You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@aurora.apache.org by "Kevin Sweeney (JIRA)" <ji...@apache.org> on 2015/06/18 23:47:00 UTC

[jira] [Created] (AURORA-1357) Consider enabling requireExplicitBindings

Kevin Sweeney created AURORA-1357:
-------------------------------------

             Summary: Consider enabling requireExplicitBindings
                 Key: AURORA-1357
                 URL: https://issues.apache.org/jira/browse/AURORA-1357
             Project: Aurora
          Issue Type: Bug
          Components: Scheduler
            Reporter: Kevin Sweeney


Right now our Guice configuration allows the creation of JIT bindings, which makes it hard to reason about which injector a provider will be created in. We should consider turning up the [requireExplicitBindings|http://google.github.io/guice/api-docs/3.0/javadoc/com/google/inject/Binder.html#requireExplicitBindings()] flag to avoid the pitfalls seen in https://reviews.apache.org/r/35627/.

Since we've released 0.8.0 with a security SPI defined in terms of Guice Modules this would be a backwards-incompatible change. We should introduce this change with a deprecation warning message when implicit bindings are detected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)