You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/25 17:44:57 UTC
[GitHub] [solr] HoustonPutman opened a new pull request, #1125: Fix useGpg signing without password
HoustonPutman opened a new pull request, #1125:
URL: https://github.com/apache/solr/pull/1125
Also make the release wizard work. It is currently broken with respect to GPG signing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] chatman commented on pull request #1125: Fix useGpg signing without password
Posted by GitBox <gi...@apache.org>.
chatman commented on PR #1125:
URL: https://github.com/apache/solr/pull/1125#issuecomment-1290954867
Thanks Houston, I'm trying this out with a new run of RC1. Might take an hour or so before I get to know if it works.
If it works, I'll merge to branch_9x and main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1125: Fix useGpg signing without password
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1125:
URL: https://github.com/apache/solr/pull/1125#issuecomment-1292169357
Ok. Gradle based signing works from the release wiz if the passphrase is in your gradle.properties though. So could still allow that as alternative to gpg agent?
For me I’m fine with gpg, but I imagine someone requested gradle signing for some reason? I don’t know that reason, so guess they have to speak up if they want to be RM in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1125: Fix useGpg signing without password
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #1125:
URL: https://github.com/apache/solr/pull/1125#issuecomment-1290977959
The new releaseWizard step should allow it to work for almost all environments. So you can go back to running it through the releaseWizard after this is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on pull request #1125: Fix useGpg signing without password
Posted by GitBox <gi...@apache.org>.
janhoy commented on PR #1125:
URL: https://github.com/apache/solr/pull/1125#issuecomment-1291581038
Does this remove gradle signing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1125: Fix useGpg signing without password
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on PR #1125:
URL: https://github.com/apache/solr/pull/1125#issuecomment-1292141008
> Does this remove gradle signing?
It does not, it removes the ability to use gradle signing via the release wizard. The `ORG_GRADLE_PROJECT_signingPassword` variable which is used to pass the password for the gradle signing method (from `buildAndPushRelease.py`) only works with the [`useInMemoryPgpKeys` function](https://docs.gradle.org/current/userguide/signing_plugin.html#sec:in-memory-keys) which we don't use. This means that the only way the python script could pass the passphrase to gradle is via a `-P` which isn't great. So much easier to just make sure release managers use the gpg method, and make sure the password is pre-cached for the gradle command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman merged pull request #1125: Fix useGpg signing without password
Posted by GitBox <gi...@apache.org>.
HoustonPutman merged PR #1125:
URL: https://github.com/apache/solr/pull/1125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org