You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/10/16 17:31:00 UTC
[GitHub] [trafficserver] bneradt opened a new pull request #7279: Add throttled log functions
bneradt opened a new pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279
Some messages get excessively noisy under high traffic conditions if
something about their mechanism goes wrong. The pipe logging feature,
for instance, will emit warning and error messages on every single log
event if the reader goes down or the pipe buffer fills up. This can
result in thousands of log messages being emitted per second, which
makes reading the logs difficult and causes disk space issues.
This commit addresses this issue by adding throttled versions of the
common logging messages so they only emit a message on some set
interval (60 seconds as a default). The following functions are added:
ThrottledStatus
ThrottledNote
ThrottledWarning
ThrottledError
These are implemented using a generic Throttler class which may also be
useful in other applications where throttling is desired.
---
This is a draft PR. The production PR will need to include at least the following:
- Configurability of the throttling interval.
- Documentation of these new log functions
- An autest to verify basic throttling functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-799856991
[approve ci]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-797602719
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-769451333
[approve ci]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-799516232
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-800610702
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt merged pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-797602719
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-717563525
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-799856991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-769451468
[approve ci docs]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall removed a comment on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bryancall removed a comment on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-769451468
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-796290254
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on a change in pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt commented on a change in pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#discussion_r596099024
##########
File path: include/tscore/Ptr.h
##########
@@ -99,10 +99,12 @@ template <class T> class Ptr
public:
explicit Ptr(T *p = nullptr);
Ptr(const Ptr<T> &);
+ Ptr(Ptr<T> &&);
Review comment:
The changes to this file are done to address a mistaken clang-analyzer issue that gets raised from this patch. (Thank you, @ywkaras, for your work on coming up with this solution.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-801303719
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop removed a comment on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
zwoop removed a comment on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-809648407
Cherry-picked to v9.1.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-799516232
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-801303719
[approve ci clang-analyzer]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-809648407
Cherry-picked to v9.1.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #7279: Add throttled log functions
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #7279:
URL: https://github.com/apache/trafficserver/pull/7279#issuecomment-719730867
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org