You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by eminency <gi...@git.apache.org> on 2015/08/19 05:01:53 UTC
[GitHub] tajo pull request: TAJO-1741: Two tables having same time zone dis...
GitHub user eminency opened a pull request:
https://github.com/apache/tajo/pull/699
TAJO-1741: Two tables having same time zone display different timestamps
includeTimezone flag is for TIMESTAMPZ type, so changed to 'false'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eminency/tajo TAJO-1741
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/699.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #699
----
commit 192c1ef505749a0ef0372c83783abc6988f446ad
Author: Jongyoung Park <em...@gmail.com>
Date: 2015-08-19T02:58:53Z
includeTimezone flag is for TIMESTAMPZ type, so changed to 'false'
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1741: Two tables having same time zone dis...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/699#issuecomment-132450929
@eminency
I missed one thing. Could you add insert tests using timezone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1741: Two tables having same time zone dis...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/699
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1741: Two tables having same time zone dis...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/699#issuecomment-132902970
+1
The patch looks good to me, and it looks enough for the unit test to verify this bug fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1741: Two tables having same time zone dis...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/699#issuecomment-132450837
+1
The change looks straightforward. I'll change your comments into a java doc format before committing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1741: Two tables having same time zone dis...
Posted by eminency <gi...@git.apache.org>.
Github user eminency commented on the pull request:
https://github.com/apache/tajo/pull/699#issuecomment-132891279
@hyunsik
Thank you for review.
I applied your suggestion right before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---