You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "andrii-korotkov-verkada (via GitHub)" <gi...@apache.org> on 2024/12/06 14:17:00 UTC
[I] Upgrade Flask to 2.3.3 [airflow]
andrii-korotkov-verkada opened a new issue, #44733:
URL: https://github.com/apache/airflow/issues/44733
### Description
Right now Flask is pinned to be <2.3 https://github.com/apache/airflow/blob/3d421f78d7046474c5684580a744f87160378935/hatch_build.py#L387-L390. Update this to be <2.4 or <3.
### Use case/motivation
This pin makes it pretty hard to use in some environments, such as Bazel-built monorepo with a Flask version higher than that. Also, an upgrade probably needs to happen eventually anyways.
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Upgrade Flask to 2.3.3 [airflow]
Posted by "andrii-korotkov-verkada (via GitHub)" <gi...@apache.org>.
andrii-korotkov-verkada commented on issue #44733:
URL: https://github.com/apache/airflow/issues/44733#issuecomment-2523465267
Ah, okay.
> We are getting rid of flask altogether anyway in Airlfow 3.
This would work too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Upgrade Flask to 2.3.3 [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #44733:
URL: https://github.com/apache/airflow/issues/44733#issuecomment-2523347267
Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Upgrade Flask to 2.3.3 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #44733:
URL: https://github.com/apache/airflow/issues/44733#issuecomment-2523450705
I am afraid it will not happen.
We are getting rid of flask altogether anyway in Airlfow 3. This limit comes from connexion 2 - latest version 2.14.2 that we are getting rid as well in Airflow 3. One of the reasons is that upgrading to Connexion 3 is non-trivial (https://github.com/apache/airflow/pull/39055 was a massive green PR that nobody had the courage to continue working on), actually it's very hard to migrate because they changed architecture completely, so we are switching to FastAPi. Because it turned out to be easier.
So ... this issue is "won't do"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Upgrade Flask to 2.3.3 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #44733: Upgrade Flask to 2.3.3
URL: https://github.com/apache/airflow/issues/44733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org