You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (Issue Comment Edited) (JIRA)" <ji...@apache.org> on 2012/03/21 09:39:42 UTC

[jira] [Issue Comment Edited] (HBASE-5584) Coprocessor hooks can be called in the respective handlers

    [ https://issues.apache.org/jira/browse/HBASE-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234124#comment-13234124 ] 

ramkrishna.s.vasudevan edited comment on HBASE-5584 at 3/21/12 8:38 AM:
------------------------------------------------------------------------

Updated patch (only testcase).  In my local it was passing.  Now added some sleep in testcase after create so that we can ensure that the postCreateHandler is called.  Pls review.
                
      was (Author: ram_krish):
    Updated patch.  In my local it was passing.  Now added some sleep after create so that we can ensure that the postCreateHandler is called.  Pls review.
                  
> Coprocessor hooks can be called in the respective handlers
> ----------------------------------------------------------
>
>                 Key: HBASE-5584
>                 URL: https://issues.apache.org/jira/browse/HBASE-5584
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-5584-1.patch, HBASE-5584.patch
>
>
> Following points can be changed w.r.t to coprocessors
> -> Call preCreate, postCreate, preEnable, postEnable, etc. in their respective handlers
> -> Currently it is called in the HMaster thus making the postApis async w.r.t the handlers
> -> Similar is the case with the balancer.
> with current behaviour once we are in the postEnable(for eg) we any way need to wait for the main enable handler to 
> be completed.
> We should ensure that we dont wait in the main thread so again we need to spawn a thread and wait on that.
> On the other hand if the pre and post api is called on the handlers then only that handler thread will be
> used in the pre/post apis
> If the above said plan is ok i can prepare a patch for all such related changes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira