[GitHub] [netbeans] lkishalmi commented on a change in pull request #2541: Gradle projects should recognize Kotlin source directories.

[GitBox <gi...@apache.org>]

lkishalmi commented on a change in pull request #2541:
URL: https://github.com/apache/netbeans/pull/2541#discussion_r525665976



##########
File path: java/gradle.java/src/org/netbeans/modules/gradle/java/api/GradleJavaSourceSet.java
##########
@@ -42,12 +42,13 @@
         "LBL_JAVA=Java",
         "LBL_GROOVY=Groovy",
         "LBL_SCALA=Scala",
+        "LBL_KOTLIN=Kotlin",
         "LBL_RESOURCES=Resources",
         "LBL_GENERATED=Generated"
     })
     public static enum SourceType {
 
-        JAVA, GROOVY, SCALA, RESOURCES,
+        JAVA, GROOVY, SCALA, KOTLIN, RESOURCES,

Review comment:
       Always add enum at the end of the list when extending an API, aslo add javadoce with @since annotation. see GENERATED




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists