[jira] [Comment Edited] (HBASE-10092) Move up on to log4j2

["Appy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-10092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296013#comment-16296013 ] 

Appy edited comment on HBASE-10092 at 12/19/17 1:50 AM:
--------------------------------------------------------

Here's ref to parameterized logging for those like me who are unfamiliar with it : https://www.slf4j.org/faq.html#logging_performance
Good that slf4j supports it.
We have is{Debug, Trace}Enabled in total of 1000 places.
If it's not just removing the guards but also formatting the message, then it's a *lot of work*. My take would be doing it overtime.

bq. As for a fatal marker, you can even rewrite those logs via a log4j2 config to use the fatal log level.
Example would help [~jvz], thanks. If it's simple enough, would prefer this.

bq. Otherwise, I'd suggest a less confusing marker name so it's not confused with a level. Something like "crash" could work?
Legacy reason. Every operator/field person/dev would be used to it.


was (Author: appy):
Here's ref to parameterized logging for those like me who are unfamiliar with it : https://www.slf4j.org/faq.html#logging_performance
Good that slf4j supports it.
We have is{Debug, Trace}Enabled in total of 1000 places.
If it's not just removing the guards but also formatting the message, then it's a *lot of work*. My take would be doing it overtime.

bq. As for a fatal marker, you can even rewrite those logs via a log4j2 config to use the fatal log level.
Example would help. If it's simple enough, would prefer this.

bq. Otherwise, I'd suggest a less confusing marker name so it's not confused with a level. Something like "crash" could work?
Legacy reason. Every operator/field person/dev would be used to it.

> Move up on to log4j2
> --------------------
>
>                 Key: HBASE-10092
>                 URL: https://issues.apache.org/jira/browse/HBASE-10092
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: stack
>            Assignee: Balazs Meszaros
>            Priority: Critical
>             Fix For: 2.0.0-beta-1
>
>         Attachments: 10092.txt, 10092v2.txt, HBASE-10092-preview-v0.patch, HBASE-10092.master.001.patch, HBASE-10092.master.002.patch, HBASE-10092.patch
>
>
> Allows logging with less friction.  See http://logging.apache.org/log4j/2.x/  This rather radical transition can be done w/ minor change given they have an adapter for apache's logging, the one we use.  They also have and adapter for slf4j so we likely can remove at least some of the 4 versions of this module our dependencies make use of.
> I made a start in attached patch but am currently stuck in maven dependency resolve hell courtesy of our slf4j.  Fixing will take some concentration and a good net connection, an item I currently lack.  Other TODOs are that will need to fix our little log level setting jsp page -- will likely have to undo our use of hadoop's tool here -- and the config system changes a little.
> I will return to this project soon.  Will bring numbers.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)