You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "adonis0147 (via GitHub)" <gi...@apache.org> on 2023/04/17 14:57:25 UTC
[GitHub] [doris] adonis0147 opened a new pull request, #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
adonis0147 opened a new pull request, #18761:
URL: https://github.com/apache/doris/pull/18761
# Proposed changes
~~Issue Number: close #xxx~~
## Problem summary
Currently, there are some useless includes in the codebase. We can use a tool named [include-what-you-use](https://github.com/include-what-you-use/include-what-you-use) to optimize these includes. By using a [strict include-what-you-use policy](https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/WhyIWYU.md), we can get lots of benefits from it.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1514910700
> Please compile this with ASAN, UBSAN to make sure it is ok
> And please confirm the ldb tool chain's version
Ping @morningman
I have checked the following scenarios with ldb_toolchain `0.14.2`:
1. build the codebase with ASAN
2. build the codebase with UBSAN
3. build the codebase with LSAN
The codebase was built successfully in all above scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1513994487
And please confirm the ldb tool chain's version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1514221129
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1514228993
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1514146706
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1511916912
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.07 seconds
stream load tsv: 431 seconds loaded 74807831229 Bytes, about 165 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230417185307_clickbench_pr_130338.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1511534032
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1511820603
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1511835815
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1514361015
run beut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1513993350
Please compile this with ASAN, UBSAN to make sure it is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1514715427
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1511860375
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1514300222
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1514314382
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1512348583
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1512437183
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 merged pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 merged PR #18761:
URL: https://github.com/apache/doris/pull/18761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18761: [chore](build) Use include-what-you-use to optimize includes (PART II)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18761:
URL: https://github.com/apache/doris/pull/18761#issuecomment-1514715549
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org