[jira] [Commented] (THRIFT-3190) In perl, a thrift set<> type should be ordered and have set manipulations

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590465#comment-14590465 ] 

Jens Geyer commented on THRIFT-3190:
------------------------------------

IIRC {{list<>}} is the only Thrift container that [guarantees ordering at all|http://thrift.apache.org/docs/types]. Especially set<> is said to be an "unordered set of values" in the document linked.So even if Perl keeps the order, any other language implementation a Perl client or server speaks to may not. 




> In perl, a thrift set<> type should be ordered and have set manipulations
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-3190
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3190
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Perl - Library
>    Affects Versions: 0.9.2
>            Reporter: James E. King, III
>            Priority: Minor
>
> Currently a set<> type in Thrift equates to a hash where the value of each type is set to 1.  The keys are interpreted as strings and therefore lose their ordering.  The TestClient for cpp sends:
> The TestServer for perl (which I am writing to verify SSL server refactoring) receives:
> $thing	HASH(0x35da228)={ -1 => '1', -2 => '1', 0 => '1', 1 => '1', 2 => '1' }	
> Note how -1 and -2 are transposed.  Further, there are no set manipulations available.
> Recommend the use of Set::Scalar as a required perl dependency for proper set operation.  This would be a breaking change but necessary to achieve proper set semantics and operations from the native thrift type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)