You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by bl...@apache.org on 2017/07/31 16:23:25 UTC

parquet-format git commit: PARQUET-1049: Make thrift version a property in pom.xml

Repository: parquet-format
Updated Branches:
  refs/heads/master d2697120b -> 66452fc8b


PARQUET-1049: Make thrift version a property in pom.xml

Author: Zoltan Ivanfi <zi...@cloudera.com>

Closes #57 from zivanfi/PARQUET-1049 and squashes the following commits:

8efc7a3 [Zoltan Ivanfi] PARQUET-1049: Make thrift version a property in pom.xml


Project: http://git-wip-us.apache.org/repos/asf/parquet-format/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-format/commit/66452fc8
Tree: http://git-wip-us.apache.org/repos/asf/parquet-format/tree/66452fc8
Diff: http://git-wip-us.apache.org/repos/asf/parquet-format/diff/66452fc8

Branch: refs/heads/master
Commit: 66452fc8b7be7b85d0ee04b309991b9dde2f6224
Parents: d269712
Author: Zoltan Ivanfi <zi...@cloudera.com>
Authored: Mon Jul 31 09:23:20 2017 -0700
Committer: Ryan Blue <bl...@apache.org>
Committed: Mon Jul 31 09:23:20 2017 -0700

----------------------------------------------------------------------
 pom.xml | 51 ++++++++++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 48 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/parquet-format/blob/66452fc8/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 64368de..b7183a9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -87,6 +87,7 @@
     <maven.compiler.target>1.6</maven.compiler.target>
     <shade.prefix>shaded.parquet</shade.prefix>
     <thrift.executable>thrift</thrift.executable>
+    <thrift.version>0.9.3</thrift.version>
   </properties>
 
   <build>
@@ -196,8 +197,8 @@
             <exclude>*/jdiff/*.xml</exclude>
             <exclude>.travis.yml</exclude>
             <exclude>licenses/**</exclude>
-            <exclude>thrift-0.9.3/**</exclude>
-            <exclude>thrift-0.9.3.tar.gz</exclude>
+            <exclude>thrift-${thrift.version}/**</exclude>
+            <exclude>thrift-${thrift.version}.tar.gz</exclude>
           </excludes>
         </configuration>
       </plugin>
@@ -218,7 +219,7 @@
     <dependency>
       <groupId>org.apache.thrift</groupId>
       <artifactId>libthrift</artifactId>
-      <version>0.9.3</version>
+      <version>${thrift.version}</version>
     </dependency>
     <dependency>
       <groupId>junit</groupId>
@@ -227,4 +228,48 @@
       <scope>test</scope>
     </dependency>
   </dependencies>
+
+  <profiles>
+    <profile>
+      <activation>
+        <os>
+          <family>!windows</family>
+        </os>
+      </activation>
+      <id>UnixClassOS</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>exec-maven-plugin</artifactId>
+            <version>1.2.1</version>
+            <executions>
+              <execution>
+                <id>check-thrift-version</id>
+                <phase>generate-sources</phase>
+                <goals>
+                  <goal>exec</goal>
+                </goals>
+                <configuration>
+                  <executable>sh</executable>
+                  <workingDirectory>${basedir}</workingDirectory>
+                  <arguments>
+                    <argument>-c</argument>
+                    <argument>${thrift.executable} -version | fgrep 'Thrift version ${thrift.version}' &amp;&amp; exit 0;
+                      echo "=================================================================================";
+                      echo "========== [FATAL] Build is configured to require Thrift version ${thrift.version} ==========";
+                      echo -n "========== Currently installed: ";
+                      ${thrift.executable} -version;
+                      echo "=================================================================================";
+                      exit 1
+                    </argument>
+                  </arguments>
+                </configuration>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
+  </profiles>
 </project>