You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/05/21 10:36:45 UTC

[GitHub] [airflow] dima-asana commented on a change in pull request #5308: [AIRFLOW-4549] skipped tasks should be ok for wait_for_downstream

dima-asana commented on a change in pull request #5308: [AIRFLOW-4549] skipped tasks should be ok for wait_for_downstream
URL: https://github.com/apache/airflow/pull/5308#discussion_r285942133
 
 

 ##########
 File path: tests/models/test_taskinstance.py
 ##########
 @@ -515,26 +516,33 @@ def run_ti_and_assert(run_date, expected_start_date, expected_end_date, expected
         done, fail = True, False
         run_ti_and_assert(date4, date3, date4, 60, State.SUCCESS, 3, 0)
 
-    def test_depends_on_past(self):
 
 Review comment:
   I replaced this explicit example and moved it to an integration test above.  The functionality here gets tested deeper in by https://github.com/apache/airflow/blob/e1c1a8dad0e01a7baa50ebe02e748429d33241fd/tests/ti_deps/deps/test_prev_dagrun_dep.py#L35-L67

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services