You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2009/12/21 15:42:18 UTC

[jira] Created: (SOLR-1679) SolrCore.execute should wrap log message construction in "if (log.isInfoEnabled())"

SolrCore.execute should wrap log message construction in "if (log.isInfoEnabled())"
-----------------------------------------------------------------------------------

                 Key: SOLR-1679
                 URL: https://issues.apache.org/jira/browse/SOLR-1679
             Project: Solr
          Issue Type: Improvement
            Reporter: Hoss Man


As mentioned by Fuad on solr-user, there is some non-trivial log message construction happening in SolreCore.execute that should be wrapped in "if (log.isInfoEnabled())" ...

http://old.nabble.com/SOLR-Performance-Tuning%3A-Disable-INFO-Logging.-to26866730.html#a26866943

...the warn level message in that same method could probably also be wrapped since it does some large string building as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1679) SolrCore.execute should wrap log message construction in "if (log.isInfoEnabled())"

Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Miller updated SOLR-1679:
------------------------------

    Attachment: SOLR-1679.patch

> SolrCore.execute should wrap log message construction in "if (log.isInfoEnabled())"
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-1679
>                 URL: https://issues.apache.org/jira/browse/SOLR-1679
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-1679.patch
>
>
> As mentioned by Fuad on solr-user, there is some non-trivial log message construction happening in SolreCore.execute that should be wrapped in "if (log.isInfoEnabled())" ...
> http://old.nabble.com/SOLR-Performance-Tuning%3A-Disable-INFO-Logging.-to26866730.html#a26866943
> ...the warn level message in that same method could probably also be wrapped since it does some large string building as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-1679) SolrCore.execute should wrap log message construction in "if (log.isInfoEnabled())"

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man resolved SOLR-1679.
----------------------------

       Resolution: Fixed
    Fix Version/s: 1.5
         Assignee: Hoss Man

Committed revision 911216.

Thanks for the suggestion Fuad.

> SolrCore.execute should wrap log message construction in "if (log.isInfoEnabled())"
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-1679
>                 URL: https://issues.apache.org/jira/browse/SOLR-1679
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 1.5
>
>         Attachments: SOLR-1679.patch
>
>
> As mentioned by Fuad on solr-user, there is some non-trivial log message construction happening in SolreCore.execute that should be wrapped in "if (log.isInfoEnabled())" ...
> http://old.nabble.com/SOLR-Performance-Tuning%3A-Disable-INFO-Logging.-to26866730.html#a26866943
> ...the warn level message in that same method could probably also be wrapped since it does some large string building as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.